Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VRFs for FPM #1343

Closed
thorvald opened this issue Oct 20, 2017 · 3 comments
Closed

Allow VRFs for FPM #1343

thorvald opened this issue Oct 20, 2017 · 3 comments

Comments

@thorvald
Copy link
Contributor

Right now, all VRFs other than 0 are filtered from FPM. Yet the code already exists in the encoding to transport the table-id in the messages. As such, a surgical fix to zfpm_is_table_for_fpm is all that's needed to export VRFs.

We've done a straight patch for this in our own code, but we'd like to upstream the change. We see three solution paths:

  1. Always enable VRFs to be sent; this changes existing behavior.
  2. Introduce a config option for no fpm filter vrfs; this opens the question of what happens to an already-open FPM connection if this option is changed.
  3. Extend the module init syntax, so that you specify -M fpm:netlink:1 or similar to enable unfiltered VRFs.

Option 3 seems the cleanest, but which option has the highest probability of PR acceptance?

@donaldsharp
Copy link
Member

From FRR's perspective turning on the passing of table-id's is a no-brainer. Would not passing down the vrf routes be there to protect the FPM listener? The FPM listener should be paying attention to the passed table-id. So I see no reason to just pass the vrf tableid(option #1)

@thorvald
Copy link
Contributor Author

Just to make sure I understand, you're saying you are in favor of option #1? That's certainly the easiest to implement :)

@donaldsharp
Copy link
Member

Yes exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants