Skip to content

Unify initial config and reconfig #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mck1117 opened this issue Apr 28, 2023 · 0 comments
Open

Unify initial config and reconfig #87

mck1117 opened this issue Apr 28, 2023 · 0 comments
Labels
🐞 bug 🐞 Something isn't working 💰 tech debt 💰 Not causing an active problem, but good to fix.

Comments

@mck1117
Copy link
Collaborator

mck1117 commented Apr 28, 2023

Code comment in engine_configuration.cpp alludes to this:

//this method is NOT currently invoked on ECU start - actual user input has to happen!`
void incrementGlobalConfigurationVersion() {

A bunch of the work done in the functions called there is similar to stuff that happens at boot. Share more of that logic!

This is the cause of #86.

@mck1117 mck1117 added 🐞 bug 🐞 Something isn't working 💰 tech debt 💰 Not causing an active problem, but good to fix. labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug 🐞 Something isn't working 💰 tech debt 💰 Not causing an active problem, but good to fix.
Projects
None yet
Development

No branches or pull requests

1 participant