Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BlackDuck security issues #49

Open
mmlinford opened this issue Oct 10, 2018 · 2 comments
Open

Fix BlackDuck security issues #49

mmlinford opened this issue Oct 10, 2018 · 2 comments

Comments

@mmlinford
Copy link
Collaborator

Right now there's a scary "1/10 (high risk)" reported by BlackDuck for our project. We should really see what we can do to remedy this. It might not be possible for all dependencies, but in those cases we can at least document why we can't resolve it.

@aosama
Copy link
Member

aosama commented Oct 10, 2018

I agree, these high risk issues are mostly from SPARK dependencies, a question would be how can we decide to exclude a dependency.

@mmlinford
Copy link
Collaborator Author

Yeah, the dependency tree is pretty big. The Maven dependency plugin has some features with the analyze goal that we can investigate, and I know that the shaded JAR plugin as an option to remove anything it thinks we don't need. I'm not saying we should release ours only as a shaded JAR, but that at least implies there's something smart enough out there that we can start with.

I think the main difficulty will be from testing. Not only should we have very good code coverage in our tests for after the dependencies are removed, we'd kind of have to brainstorm what are some ways that MSD could be called that aren't implied by simply hitting all the lines / branches / whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants