Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fhir client for Angular2 #90

Open
bunyaminsg opened this issue Feb 7, 2017 · 5 comments
Open

Fhir client for Angular2 #90

bunyaminsg opened this issue Feb 7, 2017 · 5 comments

Comments

@bunyaminsg
Copy link

Since fhir.js doesn't have an Angular2 adapter, I created an npm package and an example project to use fhir.js with Angular2. I would be glad if anyone interested in Angular could contribute these projects to make them better and more usable.

@niquola
Copy link
Member

niquola commented Feb 7, 2017

It would be nice if you will pull-request support for ng-2 :) Is it really different from ng-1 in terms of xhr?

@bunyaminsg
Copy link
Author

bunyaminsg commented Feb 7, 2017

I didn't make any changes in terms xhr, actually I didn't make any changes on the source of fhir.js :) I only used the native build of fhir.js, and created a class that use directly the methods of the native client. The only difference is that my class has a declaration file to make it importable for TypeScript/Angular2.

Since I worked on the build, not on the source, I don't know where to put my code in your repository. If you can decide how to integrate it with your project, I could do a pull-request.

@bunyaminsg
Copy link
Author

@syamraj I will appreciate to help you about this issue but can you write it to ng-fhir repository? It should be better to not keep busy fhir.js repository by the issues related with ng-fhir.

@emreavsar
Copy link

emreavsar commented May 22, 2017

hey @niquola and @bunyaminsg any updates here on a angular adapter for fhir? I'm currently using ng-fhir but I just found out that it does not return any headers in the response, and I need them.

@bunyaminsg i think it is not your task to adjust the ng-fhir (as far as I understood it is just a wrapper of the dist of fhir.js), it should be kind of a 'official' fhir-js adapter for angular (not angularjs), nah?

@bunyaminsg
Copy link
Author

@emreavsar yes, it is just a wrapper to use fhir.js client functions on angular. I'm using it by changing the dist of fhir.js according to my requirements (e.g. for custom headers). It would be great to have a more advanced, configurable and type safe angular library. I'll appreciate to contribute if there will be a work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants