fix(env): consider empty env variable as defined

FGRibreau · Apr 22, 2015 · 5e972f3 · 5e972f3
1 parent a2cf4cd
commit 5e972f3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/common-env.js b/lib/common-env.js
@@ -18,7 +18,7 @@ function env(logger, options) {
 
   return {
     getOrElse: function (key, def) {
-      if (process.env[key]) {
+      if (_.has(process.env, key)) {
         var val = _.isNumber(def) ? toInt(process.env[key]) : process.env[key];
 
         if (seemsBoolean(val)) {

diff --git a/test/env.test.js b/test/env.test.js
@@ -45,6 +45,7 @@ describe('env', function () {
       process.env.AMQP_LOGIN = 'plop';
       process.env.AMQP_CONNECT = 'tRue';
       process.env.AMQP_CONNECT2 = 'false';
+      process.env.AMQP_PASSWORD = '';
       process.env['PLOP_API[0]_A'] = 3;
     });
 
@@ -75,6 +76,7 @@ describe('env', function () {
       });
 
       t.strictEqual(config.AMQP.LoGiN, 'plop');
+      t.strictEqual(config.AMQP.PASSWORD, '');
       t.strictEqual(config.AMQP.PORT, 5672);
       t.strictEqual(config.AMQP.PLOP.ok.heyheyhey, true);
       t.strictEqual(config.AMQP.connect, true);