Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of NaN in time traces #18

Open
aseltmann opened this issue Sep 15, 2022 · 1 comment
Open

Add handling of NaN in time traces #18

aseltmann opened this issue Sep 15, 2022 · 1 comment

Comments

@aseltmann
Copy link

Hi Paul, I worked on arrtifact reduction in FCS time trace data. There, I can predict different artifacts in time traces. Currently I am removing these artifacts by deleting the artifactual parts and contracting the trace, which works quite well, but introduces small "stitching" artifacts where you put the parts of the trace together. When discussing this approach at MAF2022, Thorsten Wohland and others brought up that it should be straight forward to instead assign the artifactual parts of a trace as np.nan and deal with it in the correlation algorithm by ignoring this value in the correlation and then adjusting the normalisation in the end. I have not dealt with the correlation algorithms that deeply yet - have you thought about the handling of NaN values e.g. in multipletau?

@paulmueller
Copy link
Member

Hi Alex,
no, multipletau does not handle nans properly in such cases. I will not have time to implement this, but I would happily review a pull request. I am not sure how to properly implement this. If nan-handling is not straight-fotward, then using masked arrays might help. But I would also first have to wrap my head around those...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants