Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdsorbML: using slab without bulk information? #1021

Closed
goodwilling opened this issue Feb 18, 2025 · 2 comments · Fixed by #1064
Closed

AdsorbML: using slab without bulk information? #1021

goodwilling opened this issue Feb 18, 2025 · 2 comments · Fixed by #1064
Assignees

Comments

@goodwilling
Copy link

In AdsorbML, a slab has to be initialized with a bulk structure, even if the slab structure if explicitly given. In my understanding, an adsorbate can be put to a slab to generate an adsorption structure even if there is no bulk information. Sometimes we need to use a slab with a modified surface (for example, a single atom in the top layer is substituted by another metal atom). However, this will cause an error due to the different composition in the bulk and slab in the AdsorbML. Thank you very much.

@42n8dzydoo
Copy link

This is a very good question as I am facing a similar issue

@mshuaibii
Copy link
Collaborator

Great request. I just opened a PR with these changes - #1064. Once this lands you should update your code and be able to use any arbitrary slab object you provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants