Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP-Doc-Tags #57

Open
Gummibeer opened this issue Jan 9, 2018 · 0 comments
Open

PHP-Doc-Tags #57

Gummibeer opened this issue Jan 9, 2018 · 0 comments

Comments

@Gummibeer
Copy link

  • FACT-Finder PHP Library version: 1.2.5+src

  • PHP version: PHP 7.0.25

  • Expected behavior:
    PhpStorm, doc-tag for \FACTFinder\Adapter\Suggest::getSuggestions() returns \FACTFinder\Data\SuggestQuery[].

  • Actual behavior:
    PhpStorm, doc-tag for \FACTFinder\Adapter\Suggest::getSuggestions() returns \FACTFinder\Adapter\FACTFinder\Data\SuggestQuery[].

Expected \FACTFinder\Data\SuggestQuery[], got \FACTFinder\Adapter\FACTFinder\Data\SuggestQuery[]

  • Steps to reproduce:
use FACTFinder\Data\SuggestQuery;

class MyClass {
    /**
     * @param SuggestQuery[] $suggestions
     */
    private function myFnc1($suggestions)
    {
        // ...
    }

    private function myFnc2()
    {
        $suggest = new Suggest();
        $this->myFnc1($suggest->getSuggestions());
    }
}

In general are a lot of the doc-tags not right:

  • namespaces relative for php-doc-tag but absolute written
  • missing @param and @return but sometimes also too much from older versions
@Gummibeer Gummibeer mentioned this issue Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant