Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs is not defined when wrapped inside promisify #19

Open
cjroebuck opened this issue Aug 1, 2019 · 1 comment
Open

fs is not defined when wrapped inside promisify #19

cjroebuck opened this issue Aug 1, 2019 · 1 comment

Comments

@cjroebuck
Copy link

The const fs = require('fs') line gets stripped when using fs inside a function, (in this case promisify), leading to fs is not defined error:

test.js:

const fs = require("fs");
const { promisify } = require("util");
const writeFileAsync = promisify(fs.writeFile);`

npx babel --plugins=babel-plugin-static-fs test.js > out.js

out.js:

const {promisify} = require("util");
const writeFileAsync = promisify(fs.writeFile);
@soulofmischief
Copy link

soulofmischief commented Sep 22, 2019

I am having to discard this plugin until this issue is fixed, hopefully soon I get some time to look into it myself... but just to make a note:

Node >=10.x.x has support for fs.promises. This means that going forward, this plugin will need to support import { promises as fs } from 'fs' and similar syntax. Solving that problem might solve this problem as well, as it will remove our dependence on promisify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants