Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint Update #830

Merged
merged 1 commit into from
Jan 22, 2025
Merged

ESLint Update #830

merged 1 commit into from
Jan 22, 2025

Conversation

srikarparsi
Copy link
Contributor

@srikarparsi srikarparsi commented Jan 22, 2025 •
edited
Loading

Fixed Issues

This PR was created by Synk to update eslint so in expensify-common so that we would be less susceptible to an attack (related to slow regular expressions). That PR had conflicts so I created this one to address this change.

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    N/A (Eslint is a dev package)
  2. What tests did you perform that validates your changed worked?
    Opened up my editor and ensured that ESLint still works.

QA

  1. What does QA need to do to validate your changes?
    N/A
  2. What areas to they need to test for regressions?
    N/A

@srikarparsi srikarparsi self-assigned this Jan 22, 2025
@srikarparsi srikarparsi requested a review from a team as a code owner January 22, 2025 22:48
@melvin-bot melvin-bot bot requested review from NikkiWines and removed request for a team January 22, 2025 22:48
@NikkiWines
Copy link
Contributor

@srikarparsi is this to fix a Snyk issue? Can you fill out the OP a bit more clearly? 🙇

@srikarparsi
Copy link
Contributor Author

Yup sorry! Was going to fill it out after checking if tests has passed and it looks like it did :)

NikkiWines
NikkiWines approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NikkiWines NikkiWines merged commit 1b39e39 into main Jan 22, 2025
6 checks passed
@NikkiWines NikkiWines deleted the srikar-synkVersion branch January 22, 2025 23:42
@os-botify
Copy link
Contributor

os-botify bot commented Jan 22, 2025

🚀 Published to npm in 2.0.116 🎉

@srikarparsi srikarparsi mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

Assignees

@srikarparsi srikarparsi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikarparsi @NikkiWines