-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /profile URL to /overview #56920
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@DylanDylann could you please take a look at this PR? |
@nkdengineer : BUG Screen.Recording.2025-02-25.at.14.00.32.mov |
@DylanDylann i fixed |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-02-25.at.16.48.12.movAndroid: mWeb ChromeScreen.Recording.2025-02-25.at.16.44.16.moviOS: NativeScreen.Recording.2025-02-25.at.16.47.50.moviOS: mWeb SafariScreen.Recording.2025-02-25.at.16.42.41.movMacOS: Chrome / SafariScreen.Recording.2025-02-25.at.16.40.57.movMacOS: DesktopScreen.Recording.2025-02-25.at.16.45.30.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work thanks
@nkdengineer looks like there are conflicts to fix. Please DM me in Slack when it's updated and I can get it merged. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.7-0 🚀
|
Explanation of Change
Fixed Issues
$ #55155
PROPOSAL: #55155 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios-mweb.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
MacOS: Desktop