[CP Staging] fix: Distance rates - Change Rate to default leads to app crash. #49475

Krishna2323 · 2024-09-19T15:02:25Z

Details

Fixes regression from #49194

Fixed Issues

$ #49459
PROPOSAL: #49459 (comment)

Tests

Preconditions:

Track tax is enabled.
Workspace has at least two distance rates that have tax rate and tax reclaimable on
Each distance rate has different tax rate

Steps to reproduce:

Go to ws chat > Submit expense
Choose Distance > enter waypoints
Submit expense
Go to expense details > click on Rate
Choose Default Rate (0,67 / mile)
Verify app does not crash and user is navigated to expense details page. Chosen rate is displayed.

Verify that no errors appear in the JS console

Offline tests

Preconditions:

Track tax is enabled.
Workspace has at least two distance rates that have tax rate and tax reclaimable on
Each distance rate has different tax rate

Steps to reproduce:

Go to ws chat > Submit expense
Choose Distance > enter waypoints
Submit expense
Go to expense details > click on Rate
Choose Default Rate (0,67 / mile)
Verify app does not crash and user is navigated to expense details page. Chosen rate is displayed.

QA Steps

Preconditions:

Track tax is enabled.
Workspace has at least two distance rates that have tax rate and tax reclaimable on
Each distance rate has different tax rate

Steps to reproduce:

Go to ws chat > Submit expense
Choose Distance > enter waypoints
Submit expense
Go to expense details > click on Rate
Choose Default Rate (0,67 / mile)
Verify app does not crash and user is navigated to expense details page. Chosen rate is displayed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_reg.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web_chrome_reg_19_sep.mp4

MacOS: Desktop

Signed-off-by: krishna2323 <[email protected]>

melvin-bot · 2024-09-19T15:02:30Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-09-19T15:03:54Z

@aimane-chnaif can you please take a look, this comes from our PR.

Sorry for the ping @ntdiary :)

carlosmiceli · 2024-09-19T15:13:11Z

I can review once the video is up.

Krishna2323 · 2024-09-19T15:22:15Z

@carlosmiceli, do we need recordings for all platforms or web and android native is enough?

Signed-off-by: krishna2323 <[email protected]>

carlosmiceli · 2024-09-19T15:31:41Z

@Krishna2323 I think web and android is enough in this case.

carlosmiceli · 2024-09-19T15:32:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Krishna2323 · 2024-09-19T15:35:55Z

I need few more minutes, the tax amount is not updated optimistically for some reason. Sorry

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-09-19T16:02:10Z

@carlosmiceli, all done.

Signed-off-by: krishna2323 <[email protected]>

OSBotify · 2024-09-19T16:47:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: Distance rates - Change Rate to default leads to app crash. (cherry picked from commit 49d1b0d) (CP triggered by grgia)

OSBotify · 2024-09-19T18:49:00Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.0.38-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-09-19T23:35:45Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Distance rates - Change Rate to default leads to app crash.

d96de1f

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 requested a review from a team as a code owner September 19, 2024 15:02

melvin-bot bot requested a review from ntdiary September 19, 2024 15:02

melvin-bot bot removed the request for review from a team September 19, 2024 15:02

carlosmiceli self-requested a review September 19, 2024 15:13

carlosmiceli assigned Krishna2323 Sep 19, 2024

minor update.

533bba7

Signed-off-by: krishna2323 <[email protected]>

minor fix.

67e28f5

Signed-off-by: krishna2323 <[email protected]>

remove extra space.

ce02d0e

Signed-off-by: krishna2323 <[email protected]>

carlosmiceli approved these changes Sep 19, 2024

View reviewed changes

carlosmiceli merged commit 49d1b0d into Expensify:main Sep 19, 2024
16 checks passed

This was referenced Sep 19, 2024

Distance rates - Change Rate to default leads to app crash #49459

Closed

Deploy Checklist: New Expensify 2024-09-18 #49427

Closed

grgia added the CP Staging marks PRs that have been CP'd to staging label Sep 19, 2024

grgia changed the title ~~fix: Distance rates - Change Rate to default leads to app crash.~~ [CP Staging] fix: Distance rates - Change Rate to default leads to app crash. Sep 19, 2024

OSBotify pushed a commit that referenced this pull request Sep 19, 2024

Merge pull request #49475 from Krishna2323/krishna2323/issue/49459

55b4113

fix: Distance rates - Change Rate to default leads to app crash. (cherry picked from commit 49d1b0d) (CP triggered by grgia)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix: Distance rates - Change Rate to default leads to app crash. #49475

[CP Staging] fix: Distance rates - Change Rate to default leads to app crash. #49475

Krishna2323 commented Sep 19, 2024 •

edited

Loading

melvin-bot bot commented Sep 19, 2024

Krishna2323 commented Sep 19, 2024 •

edited

Loading

carlosmiceli commented Sep 19, 2024

Krishna2323 commented Sep 19, 2024

carlosmiceli commented Sep 19, 2024

carlosmiceli commented Sep 19, 2024 •

edited

Loading

Krishna2323 commented Sep 19, 2024

Krishna2323 commented Sep 19, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 19, 2024

[CP Staging] fix: Distance rates - Change Rate to default leads to app crash. #49475

[CP Staging] fix: Distance rates - Change Rate to default leads to app crash. #49475

Conversation

Krishna2323 commented Sep 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 19, 2024

Krishna2323 commented Sep 19, 2024 • edited Loading

carlosmiceli commented Sep 19, 2024

Krishna2323 commented Sep 19, 2024

carlosmiceli commented Sep 19, 2024

carlosmiceli commented Sep 19, 2024 • edited Loading

Reviewer Checklist

Krishna2323 commented Sep 19, 2024

Krishna2323 commented Sep 19, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 19, 2024

Krishna2323 commented Sep 19, 2024 •

edited

Loading

Krishna2323 commented Sep 19, 2024 •

edited

Loading

carlosmiceli commented Sep 19, 2024 •

edited

Loading