Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: admin can delete expenses" #49178

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Revert "fix: admin can delete expenses" #49178

merged 1 commit into from
Sep 13, 2024

Conversation

luacmartins
Copy link
Contributor

Reverts #48998

$ #49157

@luacmartins luacmartins self-assigned this Sep 13, 2024
@luacmartins luacmartins mentioned this pull request Sep 13, 2024
Closed
6 tasks
@luacmartins luacmartins marked this pull request as ready for review September 13, 2024 14:14
@luacmartins luacmartins requested a review from a team as a code owner September 13, 2024 14:14
@melvin-bot melvin-bot bot requested review from nkuoch and removed request for a team September 13, 2024 14:15
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 13, 2024

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny
mountiny approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, straight revert

@luacmartins luacmartins merged commit 8b77673 into main Sep 13, 2024
13 of 15 checks passed
@luacmartins luacmartins deleted the revert-48998-fix/46762 branch September 13, 2024 14:23
@melvin-bot melvin-bot bot added the Emergency label Sep 13, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 13, 2024

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Sep 13, 2024
@luacmartins @OSBotify
Merge pull request #49178 from Expensify/revert-48998-fix/46762
b5062d9 
Revert "fix: admin can delete expenses"

(cherry picked from commit 8b77673)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 13, 2024
@luacmartins
Copy link
Contributor Author

Straight revert, no checklist

@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Closed
30 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.34-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.34-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@nkuoch nkuoch Awaiting requested review from nkuoch

Assignees

@luacmartins luacmartins

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @mountiny