Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close account - App opens Debug console page after closing account #57341

Open
3 of 8 tasks
vincdargento opened this issue Feb 24, 2025 · 10 comments
Open
3 of 8 tasks

Close account - App opens Debug console page after closing account #57341

vincdargento opened this issue Feb 24, 2025 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@vincdargento
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Security > Close account.
  3. Enter email in email field.
  4. Click Close account.
  5. Click Yes, continue.

Expected Result:

App will return to login page.

Actual Result:

App opens Debug console page after closing account.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 24, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 24, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@stitesExpensify
Copy link
Contributor

I am suspicious of https://github.com/Expensify/App/pull/56926/files since it is directly related to the debug console

@carlosmiceli
Copy link
Contributor

@stitesExpensify what are your thoughts on re: being a blocker (in which case we should revert) vs. removing the blocker label and fixing it? I think it's not a flow that's worth blocking deployment IMO, but not super serious about it :P

@OlimpiaZurek
Copy link
Contributor

Hi! I’m Olimpia from Callstack and I’d like to work on this issue

@carlosmiceli carlosmiceli added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 25, 2025
@carlosmiceli
Copy link
Contributor

Removed blocker label because we revert was CPed. @OlimpiaZurek will reintroduce the changes in https://github.com/Expensify/App/pull/56926/files and add the fix for this issue.

@OlimpiaZurek
Copy link
Contributor

Daily update:

The root cause of this issue is the changes I introduced in my PR to make the Console Debug modal available on the SignInPage. To achieve that, I had to expose RightModalNavigator to PublicScreens. As a result, there are now two navigators after logout instead of one, causing this issue. I'm working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants