Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-03-05] [$125] Update helpdot links in flow to add company cards #56494

Open
joekaufmanexpensify opened this issue Feb 7, 2025 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@joekaufmanexpensify
Copy link
Contributor

joekaufmanexpensify commented Feb 7, 2025

Problem

The hyperlinks to HelpDot in the flow to add company cards go to the Expensify Classic resources. We did this intentionally during implementation because we hadn't yet created New Expensify resources. However, they now exist, so these hyperlinks are incorrect.

Solution

Update the hyperlinks in the add company cards flow to go to New Expensify resources. These are the changes we need to make:


Amex

Image

Amex corporate cards

Image

Amex delivery file

Image

Bank of America

Image

Capital One

Image

Chase

Image

Citibank

Image

Wells Fargo

Image

Mastercard commercial cards

Image

Mastercard distribution ID

Image

Visa commercial cards

Image

Visa feed details

Image
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892878544102513318
  • Upwork Job ID: 1892878544102513318
  • Last Price Increase: 2025-02-21
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@joekaufmanexpensify joekaufmanexpensify added the Planning Changes still in the thought process label Feb 7, 2025
@joekaufmanexpensify
Copy link
Contributor Author

@mountiny is going to take this one. However, leaving this unassigned/planning for now as I realized the URLs might change slightly because as i am working with @allgandalf on a minor change to the navigation structure for the New Expensify company cards resources.

Will assign Vit and take this off hold once that is done! That way we only need to update the links once.

@joekaufmanexpensify joekaufmanexpensify changed the title Update helpdot links in flow to add company cards [Hold] Update helpdot links in flow to add company cards Feb 7, 2025
@mountiny mountiny self-assigned this Feb 7, 2025
@melvin-bot melvin-bot bot added the Monthly KSv2 label Feb 10, 2025
@joekaufmanexpensify
Copy link
Contributor Author

Okay, redirects are in place. We're good to go here!

@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Monthly KSv2 Planning Changes still in the thought process labels Feb 20, 2025
@joekaufmanexpensify
Copy link
Contributor Author

LMK if there is anything else I can help with!

@joekaufmanexpensify joekaufmanexpensify changed the title [Hold] Update helpdot links in flow to add company cards Update helpdot links in flow to add company cards Feb 20, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2025
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Overdue labels Feb 21, 2025
@melvin-bot melvin-bot bot changed the title Update helpdot links in flow to add company cards [$250] Update helpdot links in flow to add company cards Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021892878544102513318

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Overdue labels Feb 21, 2025
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 21, 2025
@mountiny mountiny changed the title [$250] Update helpdot links in flow to add company cards [$125] Update helpdot links in flow to add company cards Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

Upwork job price has been updated to $125

@nkdengineer
Copy link
Contributor

nkdengineer commented Feb 21, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update helpdot links in flow to add company cards

What is the root cause of that problem?

Update links

What changes do you think we should make in order to solve the problem?

  1. Change this link to https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

  2. Update enableFeed.gl1025 to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-an-american-express-corporate-feed

  3. Change this link to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-an-american-express-corporate-feed

  4. Change this link to https://help.expensify.com/new-expensify/hubs/connect-credit-cards/
    ...

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Copy link
Contributor

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 21, 2025
@allgandalf
Copy link
Contributor

^ PR ready for review

@tayyab-rajja
Copy link

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the Below Hyperlinks on different sections:

Amex
Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

Amex corporate cards
Update this help article to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-an-american-express-corporate-feed

Amex delivery file
Update Where do I find the delivery file name? to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-an-american-express-corporate-feed

Bank of America
Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

Capital One
Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

Chase
Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

Citibank
Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

Wells Fargo
Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

Mastercard commercial cards
Update this help article to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-mastercard-commercial-feed
Update contact your bank to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-mastercard-commercial-feed

Mastercard distribution ID
Update Where do I find the distribution ID? to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-a-mastercard-commercial-feed

Visa commercial cards
Update this help article to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-visa-commercial-feed
Update contact your bank to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-visa-commercial-feed

Visa feed details
Update Where do I find these IDs? to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-a-visa-commercial-feed

What is the root cause of that problem?

Not an issue , needs to update the hyperlinks mentioned

What changes do you think we should make in order to solve the problem?

Update the Hyperlinks

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Needs to Check if we have already unit test and automation test written for this and updating the tests with the updated hyperlinks.

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

📣 @tayyab-rajja! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Feb 26, 2025
@melvin-bot melvin-bot bot changed the title [$125] Update helpdot links in flow to add company cards [Due for payment 2025-03-05] [$125] Update helpdot links in flow to add company cards Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @allgandalf requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Feb 26, 2025

@allgandalf @JmillsExpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

6 participants