Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-13] Improve checkout times in verifyHybridAppBuild workflow #55805

Closed
roryabraham opened this issue Jan 27, 2025 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

#55328 was merged just before I got my review in. Creating this to address some follow-up.

@roryabraham
Copy link
Contributor Author

Looks like @AndrewGable has a draft up here: #55807

But as discussed in 1:1's today, this workflow won't work for PRs from forks. We may need to step back and reevaluate the approach. I think the best approach we landed on today was a flow like this:

We could build a check that looks for a passing AdHoc build using that PR. It passes if someone has manually run an AdHoc build that has passed, and it fails if not. But the AdHoc build has to be run manually after an internal engineer verifies the code is not malicious

@AndrewGable
Copy link
Contributor

Do you think we should build for non-forks and leave a comment for the forks?

@roryabraham
Copy link
Contributor Author

Yeah, that sounds good. We could also do more than just leave a comment for forks - i.e: look for a passing AdHoc build workflow for the PR, and fail the check if it's not found

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 3, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 6, 2025
@melvin-bot melvin-bot bot changed the title Improve checkout times in verifyHybridAppBuild workflow [Due for payment 2025-02-13] Improve checkout times in verifyHybridAppBuild workflow Feb 6, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-13. 🎊

@roryabraham
Copy link
Contributor Author

This is done, no payments due, closing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants