-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Due for payment 2025-02-13] Improve checkout times in verifyHybridAppBuild workflow #55805
Comments
Looks like @AndrewGable has a draft up here: #55807 But as discussed in 1:1's today, this workflow won't work for PRs from forks. We may need to step back and reevaluate the approach. I think the best approach we landed on today was a flow like this:
|
Do you think we should build for non-forks and leave a comment for the forks? |
Yeah, that sounds good. We could also do more than just leave a comment for forks - i.e: look for a passing AdHoc build workflow for the PR, and fail the check if it's not found |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-13. 🎊 |
This is done, no payments due, closing it out |
#55328 was merged just before I got my review in. Creating this to address some follow-up.
The text was updated successfully, but these errors were encountered: