-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR - Tooltip - The educational tooltip for a new account is wrong #54701
Comments
Triggered auto assignment to @mallenexpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The educational tooltip for a new account is wrong What is the root cause of that problem?We are using the App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx Lines 143 to 146 in e5108a1
App/src/components/ProductTrainingContext/TOOLTIPS.ts Lines 73 to 82 in e5108a1
and value text is Lines 5593 to 5597 in e5108a1
What changes do you think we should make in order to solve the problem?To resolve this issue, we just need to update the translation as expected in this ticket. Lines 5593 to 5597 in e5108a1
workspaceChatCreate: {
part1: 'Get started! Submit your',
part2: ' first expense',
part3: ' here!',
}, What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?This is a translation issue; no unit test is needed What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Looks like a regression from #54263 cc: @ishpaul777 |
@rayane-djouah fixed this in this PR #54710 |
Fixed in b7d5186 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54344
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 14.6.1
App Component: Other
Action Performed:
1.Log in as User A, an account that owns a workspace
2.Create a new account B
3.On A, Invite B to the workspace
4.On B, open the workspace chat
Expected Result:
The tooltip shows over the composer's Create button saying "Get started! Submit your first expense"
Actual Result:
The educational tooltip for a new account over the composer's Create button says "Submit your expense" instead of "Get started! Submit your first expense"
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6704693_1735686882683.Recording__322.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: