Wallet - Account number field shows two error messages when it is empty

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Wallet.
3. Click Add bank account.
4. Select Malaysia as country if not selected.
5. Without entering Account number, click Next.

Expected Result:

Account number field should only show one error message (This field is required) when it is empty.

Actual Result:

Account number field shows two error messages when it is empty -
This field is required.
Beneficiary Account Number is invalid. Value should be 1 to 50 characters long.

It should only show "Beneficiary Account Number is invalid. Value should be 1 to 50 characters long." after entering invalid account number.

The same issue happens with Bank account holder field.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6704690_1735685441395.20250101_064755.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Offending PR: #52322

App/src/pages/settings/Wallet/InternationalDepositAccount/utils.ts

Lines 130 to 139 in e5108a1

	function getValidationErrors(values: FormOnyxValues<typeof ONYXKEYS.FORMS.INTERNATIONAL_BANK_ACCOUNT_FORM>, fieldsMap: CorpayFieldsMap, translate: LocaleContextProps['translate']) {
	const errors = {};
	for (const fieldName in fieldsMap) {
	if (!fieldName) {
	// eslint-disable-next-line no-continue
	continue;
	}
	if (fieldsMap[fieldName].isRequired && values[fieldName] === '') {
	ErrorUtils.addErrorMessage(errors, fieldName, translate('common.error.fieldRequired'));
	}

I think we need to add return statement here

App/src/pages/settings/Wallet/InternationalDepositAccount/utils.ts

Lines 137 to 139 in e5108a1

	if (fieldsMap[fieldName].isRequired && values[fieldName] === '') {
	ErrorUtils.addErrorMessage(errors, fieldName, translate('common.error.fieldRequired'));
	}

[jliexpensify]

Assigning @DylanDylann and @MonilBhavsar as they worked on the offending PR.

[DylanDylann]

@shubham1206agra Could you please fix this bug?

[MonilBhavsar]

@joekaufmanexpensify curious for your thoughts. In this case, should we display, "required" error first and then if user's input is out of 1-50 range, then display the another error?

We can discuss here https://expensify.slack.com/archives/C01GTK53T8Q/p1735689150858259

[izarutskaya]

Hi @MonilBhavsar We have similar issue in Account Holder Name Field and Beneficiary bank branch name. Should we need create a separate issue or it is the same? Thank you

[shubham1206agra]

@izarutskaya No

[shubham1206agra]

No

[MonilBhavsar]

No separate issue is required 👍

[MonilBhavsar]

Closing as we're tracking in #54743