Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-11] [HOLD for payment 2024-12-09] iOS/Android - Track expense & Log in - Background turns blank when educational modal comes up #53342

Closed
4 of 8 tasks
IuliiaHerets opened this issue Nov 30, 2024 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Issue 1:

Precondition:

  • Use an account that has "Track expense" instead of "Create expense".
  1. Launch ND or hybrid app.
  2. Open FAB.
  3. Open Track expense.

Issue 2:

  1. Create a new account on Old Dot.
  2. Log in to the same account for the first time on hybrid app.
  3. App will auto redirect to ND on hybrid app.

Expected Result:

Background will not turn blank when educational modal comes up.

Actual Result:

Background turns blank when educational modal comes up.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6680793_1732987997742.track_expense_video_modal.mp4
Bug6680793_1732987997761.new_user_video_modal.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abekkala
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 30, 2024

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 30, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 1, 2024
@mountiny
Copy link
Contributor

mountiny commented Dec 1, 2024

This one does not seem to be a blocker to me but we should fix it for sure

@kirillzyusko @hannojg @chrispader

@mountiny mountiny assigned mountiny and unassigned dangrous Dec 2, 2024
@mountiny mountiny moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 2, 2024
@adamgrzybowski
Copy link
Contributor

@mountiny I will take a look at this one

@shubham1206agra
Copy link
Contributor

@adamgrzybowski Let me know when you are ready for review. I can start doing the review.

@adamgrzybowski
Copy link
Contributor

@shubham1206agra You can start. I am currently recording videos and got a little stuck on building android 😄

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Dec 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-09. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 2, 2024

@mountiny @abekkala @adamgrzybowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

mountiny commented Dec 3, 2024

@shubham1206agra can you please complete the checklist? Thanks!

@garrettmknight garrettmknight moved this from Bugs and Follow Up Issues to Hold for Payment in [#whatsnext] #expense Dec 3, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-09] iOS/Android - Track expense & Log in - Background turns blank when educational modal comes up [HOLD for payment 2024-12-11] [HOLD for payment 2024-12-09] iOS/Android - Track expense & Log in - Background turns blank when educational modal comes up Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-11. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 4, 2024

@shubham1206agra @abekkala @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 9, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Payment Summary

Upwork Job

BugZero Checklist (@abekkala)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2024
@abekkala
Copy link
Contributor

@shubham1206agra can you please complete the checklist? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2024
@abekkala
Copy link
Contributor

PAYMENT SUMMARY FOR DEC 11

@abekkala
Copy link
Contributor

@shubham1206agra friendly bump here for checklist - once completed I can issue payment

@shubham1206agra
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/49937/files#r1884148854

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: Not Required

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

No tests required as this issue was a deploy blocker and tests is already in TestRail.

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

@abekkala, @mountiny, @shubham1206agra, @adamgrzybowski Whoops! This issue is 2 days overdue. Let's get this updated quick!

@shubham1206agra
Copy link
Contributor

@abekkala Can you please pay here?

@abekkala
Copy link
Contributor

@shubham1206agra yes - I did post summary on day of payment due (dec 11) but checklist was not completed until Dec 13.
You'll want to make sure that you're posting the checklist items before or on day of payment due.

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
@abekkala
Copy link
Contributor

@shubham1206agra payment sent and contract ended - thank you! 🎉

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

6 participants