Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to bulk select cards from the same bank in the Card filter on the Search page #53231

Open
luacmartins opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

We're in the final implementation phase for card feeds in NewDot, and as part of that initiative, we need to add a way for admins to bulk select all cards from a certain feed.

Rather than add two separate filters (and the accompanying search syntax), we're going to add a way to bulk select a whole series of cards in the Card filter. The benefit of this is that we prevent search "collisions" on two separate filters. For example, imagine that we had a filter for Feed. If you selected Chase for that option, you would also be selecting all Card numbers that also belonged to the same feed. However, in our current logic the Card filter would be empty.

Long story story, a feed is just a way of bulk selecting cards. Similarly, the Card filter is already by design a way to select one or more cards. As a result, we're going to do the following:

  • Keep the name of the Card filter
  • Within the Card filter, admins will see two sections: Card feeds and Individual cards (note for emphasis: the workspace role for member never sees the Card feeds section)
  • Further, within the Card feeds section, if a user has more than one feed, then we'll append either the domain name or the workspace name (e.g. All Expensify - [workspace name] or All Expensify - [domain]. The domain name only applies for domain feeds, and the workspace feed only applies for workspace feeds. These names are truncated where applicable.
  • When a value is selected in the Card feeds section, that's equivalent to a user individually selecting all individual cards. However, we don't do that when a feed is selected, as the card feed is it's own distinct selection.
  • It's also worth noting that it's possible to select an entire feed as well as individual cards that may not be part of the same feed. Similarly, if a feed is chosen and individual cards within the same feed are also chosen, that's the same as just selecting the feed.
  • Finally as a reminder, the search input only appears when a given list has more than 8 options. This is our standard for when the search input is shown versus not, though I'm including this as a reminder.

Taken together, the updated filter will look like this.

image

@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Nov 27, 2024
@luacmartins luacmartins self-assigned this Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 27, 2024
@luacmartins
Copy link
Contributor Author

@Kicu would you or someone from SWM want to take this one?

@JmillsExpensify
Copy link

Taking assignment on this one

@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

4 participants