Investigate why the onboarding modal was being re-shown and resulting in errors.

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.66-8
Reproducible in staging?: N
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): See thread.
Logs: See thread, but the CompleteGuidedSetup command logs are here.
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation #convert thread

Action Performed:

Note: This is a bit of a "best guess" situation to try and recreate the conditions we saw.

1. Sign-up on NewDot
2. Don't complete the onboarding modal, such that hasCompletedGuidedSetupFlow remains false.
3. Close the browser tab
4. Invite that user to a workspace that has isPolicyExpenseChatEnabled set to true via OldDot .
5. Go to expensify.com with that new account and sign-in
6. Click Support > Concierge to be redirected to NewDot
7. Observe the onboarding modal appears
8. Choose "Manage my team's expenses" > 1-10 > QBO > confirm
9. Observe the onboarding modal reappears and you start running into errors.

Expected Result:

Suggestion: If a user with hasCompletedGuidedSetupFlow===false is invited to a workspace, set it to true, so we don't show the onboarding modal.
Bug: User shouldn't be hitting this 402 when trying to complete the onboarding steps:

Throw ExpException - d3f30e8e3ec40a7e653ef74717c257bf ~~ message: '402 Invalid message data' exceptionMessage: 'Auth CompleteGuidedSetup returned an error' exceptionFile: '/git/releases/expensify.com/26cdf1f/lib/Auth.php' exceptionLine: '133' exceptionCode: '402'

Actual Result:

Can't complete the onboarding modal and results in errors on task creation.

Workaround:

No, they can't get past the onboarding modal.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari --- the user was on Windows Chrome (Windows NT 10.0; Win64; x64)
• MacOS: Desktop

Screenshots/Videos

Internal FS

View all open jobs on GitHub

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.