Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-05] [HOLD FOR PAYMENT OCTOBER 31st][$250] Merge App Attendee tracking feature branch #51335

Closed
Julesssss opened this issue Oct 23, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Oct 23, 2024

Details

We want to merge the unfinishedfeature-attendeeTracking branch into main. We have tested individual changes when merging individual PRs to this branch.

This project has been put on hold due to project prioritisation changes. Keeping this feature branch aligned with main is already complex due to conflicts. We are simply blocking the future from use here.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021849762648933080726
  • Upwork Job ID: 1849762648933080726
  • Last Price Increase: 2024-10-25
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
@Julesssss Julesssss added Reviewing Has a PR in review Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Oct 23, 2024
@Julesssss Julesssss self-assigned this Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 23, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@Julesssss
Copy link
Contributor Author

I forgot the new feature label assigned to the design team, sorry!

@Expensify Expensify deleted a comment from melvin-bot bot Oct 23, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Oct 23, 2024

cc @Julesssss

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Oct 23, 2024

Oh
I reviewed all previous PRs related to this project
If need additional help here
I am available !

cc @Julesssss

@Julesssss
Copy link
Contributor Author

Thanks for the reminder, we can stick with @fedirjh for this one as there isn't much to review though.

@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021849762648933080726

@melvin-bot melvin-bot bot changed the title Merge App Attendee tracking feature branch [$250] Merge App Attendee tracking feature branch Oct 25, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 25, 2024
@Julesssss Julesssss removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 25, 2024
@Julesssss Julesssss changed the title [$250] Merge App Attendee tracking feature branch [HOLD FOR PAYMENT OCTOBER 31st][$250] Merge App Attendee tracking feature branch Oct 25, 2024
@joekaufmanexpensify
Copy link
Contributor

Payment due later this week

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 29, 2024
@melvin-bot melvin-bot bot changed the title [HOLD FOR PAYMENT OCTOBER 31st][$250] Merge App Attendee tracking feature branch [HOLD for payment 2024-11-05] [HOLD FOR PAYMENT OCTOBER 31st][$250] Merge App Attendee tracking feature branch Oct 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @fedirjh requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Oct 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fedirjh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@Julesssss
Copy link
Contributor Author

Hi @joekaufmanexpensify, this is ready for payment now

@joekaufmanexpensify
Copy link
Contributor

Cool cool. Only payment here is $250 to @fedirjh for C+ review via NewDot.

@joekaufmanexpensify
Copy link
Contributor

@fedirjh please request payment at your earliest convenience. Closing as this is otherwise all set

Copy link

melvin-bot bot commented Nov 4, 2024

@Julesssss @joekaufmanexpensify Be sure to fill out the Contact List!

@garrettmknight
Copy link
Contributor

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants