Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split - When creating a Split expense the user is shown as Hidden #51003

Closed
2 of 8 tasks
IuliiaHerets opened this issue Oct 17, 2024 · 18 comments
Closed
2 of 8 tasks

Split - When creating a Split expense the user is shown as Hidden #51003

IuliiaHerets opened this issue Oct 17, 2024 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5093942
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Open New Expensify app
  2. Log in with a new HT account
  3. Create a WS
  4. Navigate to the WS room
  5. Navigate + Menu - Submit expense - Manual
  6. Create an expense
  7. Navigate + Menu - Split expense - Manual
  8. Enter the amount - Next

Expected Result:

The user should not be displayed as Hidden when creating a split expense

Actual Result:

After creating an expense in a new WS, when creating a Split expense the user is shown as Hidden

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6637313_1729146541766.Recording__182__3_.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 17, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@lakchote
Copy link
Contributor

Found the culprit #47370

cc @jasperhuangg @parasharrajat @Krishna2323

@lakchote
Copy link
Contributor

Asked for a CP here

@Krishna2323
Copy link
Contributor

@lakchote thanks for the revert and sorry for the regression :(

@lakchote
Copy link
Contributor

@lakchote thanks for the revert and sorry for the regression :(

No worries, edge cases happen!

@lanitochka17
Copy link

The issue is still reproducible

bandicam.2024-10-18.01-12-02-134.mp4

@rojiphil
Copy link
Contributor

I think this should also get fixed with the latest CP fix here
cc @lakchote @lanitochka17

@c3024
Copy link
Contributor

c3024 commented Oct 18, 2024

Yea, I don't see it reproducible on staging now.

@lakchote
Copy link
Contributor

Not reproducible on staging now, yes.

@lakchote
Copy link
Contributor

lakchote commented Oct 18, 2024

@Krishna2323 sorry for reverting your PR it looks like some edge case induced me in error.

Screen.Recording.2024-10-18.at.07.53.17.mov

As you can see in the video, there is Concierge shown as the participant instead of the user, while checking out your merge commit. I didn't revert in the video because your PR is already reverted on the main branch. And I don't have the problem on main branch.

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Oct 18, 2024
@neil-marcellini
Copy link
Contributor

@Krishna2323 sorry for reverting your PR it looks like some edge case induced me in error.

@lakchote does that mean that we can re-apply this PR? #47370

@rayane-djouah
Copy link
Contributor

@lakchote I think we can close this issue since it was fixed in #51040 (comment)

@lakchote
Copy link
Contributor

lakchote commented Oct 21, 2024

@Krishna2323 sorry for reverting your PR it looks like some edge case induced me in error.

@lakchote does that mean that we can re-apply this PR? #47370

Yes, we should. I've created an un-revert PR that was CP'ed to staging.

@mallenexpensify
Copy link
Contributor

K, sounds like we agree we should close this so.. I'm closing. Comment/reopen if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants