[HOLD for payment 2024-10-29] [$250] Search - No tooltip when hovering over the search icon

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Open any report.
3. Hover over search icon on the top right.

Expected Result:

There will be tooltip when hovering over the search icon.

Actual Result:

There is no tooltip when hovering over the search icon.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637206_1729134483527.tooltip.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846935135638966053
• Upwork Job ID: 1846935135638966053
• Last Price Increase: 2024-10-17

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - No tooltip when hovering over the search icon

What is the root cause of that problem?

We don't wrap this icon in a Tooltip component

What changes do you think we should make in order to solve the problem?

We should wrap this icon in a Tooltip component with text is search

What alternative solutions did you explore? (Optional)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The SearchButton component does not have a tooltip:

App/src/components/Search/SearchRouter/SearchButton.tsx

Line 26 in 935067e

<PressableWithoutFeedback

What changes do you think we should make in order to solve the problem?

Wrap Tooltip around whose content can be "Find"

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MonilBhavsar]

Not a blocker. Commented on the offending PR. Would allow PR author to fix it

[rayane-djouah]

Thanks!

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and since I implemented Search 2.4 I’d like to work on this issue!

[MonilBhavsar]

@SzymczakJ assigned you, thanks!

[joekaufmanexpensify]

I assume we're going to try and have @rayane-djouah review this one too, as they were C+ on the PR that caused the regression as well?

[luacmartins]

Yes, I assgined @rayane-djouah to the issue too.

[joekaufmanexpensify]

PR out on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Search router polish  #50921

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment (Needs manual offer from BZ)
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[joekaufmanexpensify]

@rayane-djouah can you complete BZ here so we can prep for payment?

[rayane-djouah]

BugZero Checklist

• The PR that introduced the bug has been identified. Link to the PR: Add SearchRouter component and context to display it #48785
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48785/files#r1819588103
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. This was treated as a follow-up PR as part of the search project, and regression tests will be added during the project wrap-up. Additionally, this bug was caught during regression testing, so there is likely already a test case for it
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[joekaufmanexpensify]

TY! all set to issue payment.

[joekaufmanexpensify]

We only need to pay @rayane-djouah $250 here for C+ via Upwork.

[joekaufmanexpensify]

@rayane-djouah offer sent for $250!

[rayane-djouah]

@joekaufmanexpensify Offer accepted, thank you!

[joekaufmanexpensify]

@rayane-djouah $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set. Thanks everyone!