[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Open report.
3. Click search on the top right.
4. Enter the name of user with no chat history (must be the user whose chat has never been opened before).
5. Click on the user.

Expected Result:

The chat with that user will open.

Actual Result:

Nothing happens after clicking on user with no chat history on Search.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637208_1729134722149.20241017_111010.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-17 07:33:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after clicking on user with no chat history on Search.

What is the root cause of that problem?

We use dismissModalWithReport to navigate to the newly created report with the new user:

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 163 to 165 in c7847b9

	} else if ('login' in item) {
	Report.navigateToAndOpenReport(item?.login ? [item.login] : []);
	}

App/src/libs/actions/Report.ts

Lines 1048 to 1050 in c7847b9

	if (shouldDismissModal) {
	Navigation.dismissModalWithReport(report);
	} else {

But since we open from Report screen and it is not included in these screens:

App/src/libs/Navigation/dismissModalWithReport.ts

Lines 36 to 46 in c7847b9

	switch (lastRoute?.name) {
	case NAVIGATORS.FULL_SCREEN_NAVIGATOR:
	case NAVIGATORS.LEFT_MODAL_NAVIGATOR:
	case NAVIGATORS.RIGHT_MODAL_NAVIGATOR:
	case SCREENS.NOT_FOUND:
	case SCREENS.ATTACHMENTS:
	case SCREENS.TRANSACTION_RECEIPT:
	case SCREENS.PROFILE_AVATAR:
	case SCREENS.WORKSPACE_AVATAR:
	case SCREENS.REPORT_AVATAR:
	case SCREENS.CONCIERGE:

causing the dismissModalWithReport does not navigate.

What changes do you think we should make in order to solve the problem?

Add SCREENS.REPORT to the above cases.

[Kicu]

I will take a look at this one.

[rayane-djouah]

Thanks @Kicu
cc @luacmartins

[luacmartins]

Taking this over since it came from a Search PR.

[Kicu]

Fix ready in a PR.
I was mostly testing on a non-existing user account, but Im 99% sure it's the same behaviour whether this is an actual user that you never talked with or a completely fake user account.

[luacmartins]

This is fixed in staging.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Search back button on mWeb and report opening in Search #51032

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Search back button on mWeb and report opening in Search #51032

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: