[Payment Due 2024-10-07] There are reports with GBR indicators that appear when search for them, but they do not show up in the LHN for approval.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726515980761009

Action Performed:

1. Create a Collect workspace
2. Invite a submitter and two approvers
3. Enable Workflows + Approvals
4. Set Approver A as the workspace approver
5. As the submitter, submit an expense in your workspace chat
6. As the admin, change the approver from Approver A to Approver B

Expected Result:

Approver A should be removed from the workspace chat, but they should retain the report from the submitter in LHN with GBR.

Actual Result for @coleaeason:

Approver A doesn't have the report in LHN. The report shows when searched for and shows as GBR when it's in his LHN after searching.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[garrettmknight]

Asked in thread for more details around the reports.

[Beamanator]

Commenting to keep an eye on this. This should have been fixed w/ these PRs:

• Show report in LHN if user is expense report manager without access to parent policyChat #48362
• Show expense report in LHN even if report not in submitted state/status #48661

Basically as of these PRs, the expense reports should be showing in the LHN AS LONG AS all of these are true:

1. isExpenseReport(report)
2. report?.hasParentAccess === false
3. report?.managerID === currentUserAccountID
   • We might want to remove this :D

[garrettmknight]

Assigning @Beamanator based on his theory above.

[Beamanator]

Will get to this today 🙏

[Beamanator]

PR is up! ^

[jjcoffee]

@JmillsExpensify Could I get assigned here for payment as the PR reviewer? Thanks!

[jjcoffee]

Deployed to production yesterday, so should be due for payment 2024-10-07.

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - followup to Show expense report in LHN even if report not in submitted state/status #48661
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes - if one doesn't already exist
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal
Pre-requisites

• Have a control policy with policy expense chats and "Advanced Approvals" enabled (members tab)
• Have 3 non-admin users, 1 submitter and 2 approvers
• The submitter has submitsTo set to Approver 1
• Approver 1 and Approver 2 should NOT have a forwardsTo set.

1. [Submitter] Go to the control policy's workspace chat
2. [Submitter] Submit an expense and submit the report to Approver 1
3. [Approver 1] Verify that you can see the submitted expense
4. [Policy Owner] Go to the approval workflow settings (either NewDot or OldDot)
5. [Policy Owner] Change the submitter's submitsTo to Approver 2
6. [Approver 1] Verify you no longer have access to the workspace chat
7. [Approver 1] Verify that you can still see the expense report in the LHN
8. [Approver 1] Verify that you can open the expense report and you see the Approve button
9. [Approver 1] Click Approve, and verify it works without errors
10. [Approver 1] Click onto a different report and verify the expense report still shows up in LHN

Do we agree 👍 or 👎

[jjcoffee]

@JmillsExpensify Friendly bump to handle payment here. Thanks! 🙏

[melvin-bot]

@JmillsExpensify, @Beamanator, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify, @Beamanator, @jjcoffee Still overdue 6 days?! Let's take care of this!

[JmillsExpensify]

Payment summary: $250 to @jjcoffee for PR review and testing.

[JmillsExpensify]

Offer sent, apologies for the delay.

[jjcoffee]

@JmillsExpensify Accepted, thanks!

[JmillsExpensify]

All paid out!