Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company cards - AMEX icon is cut off on Android and iOS app #49047

Closed
2 of 6 tasks
IuliiaHerets opened this issue Sep 12, 2024 · 8 comments
Closed
2 of 6 tasks

Company cards - AMEX icon is cut off on Android and iOS app #49047

IuliiaHerets opened this issue Sep 12, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48119
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Company cards feature is enabled.
  1. Launch New Expensify app.
  2. Go to https://staging.new.expensify.com/settings/workspaces/policyID/company-cards/add-card-feed

Expected Result:

AMEX icon will be displayed in full card (web behavior).

Actual Result:

AMEX icon is cut off on Android and iOS app.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6600585_1726112865401.ScreenRecording_09-12-2024_07-14-53_1.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 12, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Sep 12, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 12, 2024
@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-control

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Pujan92
Copy link
Contributor

Pujan92 commented Sep 12, 2024

I think company card feature is not opened for QA yet, this will be handled by @waterim

@waterim
Copy link
Contributor

waterim commented Sep 12, 2024

@joekaufmanexpensify Should it be closed as Company cards is under NO QA label?

@koko57
Copy link
Contributor

koko57 commented Sep 12, 2024

  • not a deploy blocker as it's under beta

@joekaufmanexpensify
Copy link
Contributor

Yeah, let's close for now. This feature is still in implementation. We're going to start comprehensive manual testing soon, but any QA now is premature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants