Company cards - "What's the Amex delivery file name" is missing a question mark

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48119
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Company cards feature is enabled.

1. Go to https://staging.new.expensify.com/settings/workspaces/policyID/company-cards/add-card-feed
2. Select AMEX.
3. Click Next.

Expected Result:

The sentence "What's the Amex delivery file name" should have a question mark.

Actual Result:

The sentence "What's the Amex delivery file name" is missing a question mark.

The sentence "What's the Mastercard distribution ID" (Mastercard) is also missing the question mark.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6600584_1726112863273.20240912_065738.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The sentence "What's the Amex delivery file name" is missing a question mark.

What is the root cause of that problem?

This copy is not correct

App/src/languages/en.ts

Line 2828 in 2830add

title: `What's the Amex delivery file name`,

What changes do you think we should make in order to solve the problem?

Add question mark to the copy.

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The sentences "What's the Amex delivery file name" and "What's the Mastercard distribution ID" (Mastercard) is missing a question mark.

What is the root cause of that problem?

• Its not included in en.ts file

What changes do you think we should make in order to solve the problem?

• include ? at both place
  

  App/src/languages/en.ts

  Line 2828 in 2830add

  title: `What's the Amex delivery file name`,

  
  

  App/src/languages/en.ts

  Line 2832 in 2830add

  title: `What's the Mastercard distribution ID`,

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[grgia]

Demoting from a deploy blocker, should be fixed by @waterim

[waterim]

Company cards are under NO QA label

[ChavdaSachin]

Additionally I have found we are missing a ? here as well

App/src/languages/es.ts

Line 566 in 2830add

`¿Estás seguro de que quieres eliminar este ${action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? 'gasto' : 'comentario'}`,

please fix along.

[waterim]

@joekaufmanexpensify Should it be closed as Company cards is under NO QA label?

[koko57]

• not a deploy blocker as it's under beta

[joekaufmanexpensify]

Yeah, let's close for now. This feature is still in implementation. We're going to start comprehensive manual testing soon, but any QA now is premature.