[HOLD for payment 2024-10-02] [$250] [Workspace feeds] Virtual card flow should not have a card name as suggested text

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725488084068029

Action Performed:

1. Sign up with gmail account added to Workspace feeds beta
2. Enable Expensify Card in more features
3. Complete setup using credentials from option 3 in the SO
4. Go through issue card flow, land on card name step

Expected Result:

Card name should not have suggested text in the virtual card step

Actual Result:

We show a suggested name

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021832329231446894325
• Upwork Job ID: 1832329231446894325
• Last Price Increase: 2024-09-07
• Automatic offers:
• ishpaul777 | Reviewer | 103858804

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Virtual card flow should not have a card name as suggested text

What is the root cause of that problem?

We are passing a default value here.

App/src/pages/workspace/expensifyCard/issueNew/CardNameStep.tsx

Line 96 in 67333b9

defaultValue={issueNewCard?.data?.cardTitle ?? defaultCardTitle}

What changes do you think we should make in order to solve the problem?

We can pass undefined here

App/src/pages/workspace/expensifyCard/issueNew/CardNameStep.tsx

Line 96 in 67333b9

defaultValue={issueNewCard?.data?.cardTitle ?? defaultCardTitle}

What alternative solutions did you explore? (Optional)

we can remove defaultValue

App/src/pages/workspace/expensifyCard/issueNew/CardNameStep.tsx

Line 96 in 67333b9

defaultValue={issueNewCard?.data?.cardTitle ?? defaultCardTitle}

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Virtual card flow should not have a card name as suggested text

What is the root cause of that problem?

• We always display the suggestion name, regardless the card is physical or virtual:
  

  App/src/pages/workspace/expensifyCard/issueNew/CardNameStep.tsx

  Line 96 in 67333b9

  defaultValue={issueNewCard?.data?.cardTitle ?? defaultCardTitle}

What changes do you think we should make in order to solve the problem?

• We should update:
  

  App/src/pages/workspace/expensifyCard/issueNew/CardNameStep.tsx

  Line 32 in 67333b9

  const defaultCardTitle = `${userName}'s Card`;

    const defaultCardTitle = data?.cardType !== CONST.EXPENSIFY_CARD.CARD_TYPE.VIRTUAL ? `${userName}'s Card` : '';

so we will only display suggestion name if the card type is not virtual.

What alternative solutions did you explore? (Optional)

• If we don't want to display the suggestion name in both card type, just need to update:
  

  App/src/pages/workspace/expensifyCard/issueNew/CardNameStep.tsx

  Line 96 in 67333b9

  defaultValue={issueNewCard?.data?.cardTitle ?? defaultCardTitle}

  
  to:

                    defaultValue={issueNewCard?.data?.cardTitle}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021832329231446894325

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[twisterdotcom]

Oh wait, I just added External because I thought this was fine to add, but I am seeing now that you assigned @mountiny. Just want to clarify for proposers now that this may be internal, but... it does seem like we could get a contributor to do it.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[mountiny]

We are planning to handle these as workspace feeds polish to get it released asap. Rajat and Ishpaul will tackle it

[mountiny]

@parasharrajat Can you also link this to the PR you are working on?

[parasharrajat]

Linked

[trjExpensify]

Hit prod two weeks ago, @parasharrajat and @ishpaul777 need paying @twisterdotcom.

[mountiny]

$250 to @parasharrajat and to @ishpaul777

[twisterdotcom]

Payment Summary:

• @parasharrajat paid $250 via Manual Requests (C+)
• @ishpaul777 paid $250 via Upwork here (Contributor)

[parasharrajat]

Payment requested as per #48732 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat