[$250] Company cards - “Assign card” and “Settings” buttons are below intro modal

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace settings > Company Cards.

Expected Result:

“Assign card” and “Settings” buttons should be at the top of the of the page and above the intro modal.

Actual Result:

“Assign card” and “Settings” buttons are below the intro modal.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6591344_1725334298042.ScreenRecording_09-03-2024_11-27-06_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fcc55f0c4c0d495b
• Upwork Job ID: 1830935252821009051
• Last Price Increase: 2024-09-03

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fcc55f0c4c0d495b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-03 11:54:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign card” and “Settings” buttons are below intro modal

What is the root cause of that problem?

In narrow layout we are adding this after this code block so in narrow layouts it is displayed below the modal

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Line 90 in 4fe86eb

{shouldUseNarrowLayout && <View style={[styles.pl5, styles.pr5]}>{getHeaderButtons()}</View>}

What changes do you think we should make in order to solve the problem?

We should move this line of code above this line.

 {shouldUseNarrowLayout && <View style={[styles.pl5, styles.pr5]}>{getHeaderButtons()}</View>}
                {!isFeedAdded && <WorkspaceCompanyCardPageEmptyState route={route} />}
                {isFeedAdded && <WorkspaceCompanyCardsFeedAddedEmptyPage />}

We might also need to adjust styles

What alternative solutions did you explore? (Optional)

[VickyStash]

This issue will be fixed in this PR. This functionality is still under active development.
cc @joekaufmanexpensify @koko57

[joekaufmanexpensify]

Ah awesome. Perhaps we can close this one then?

[VickyStash]

@joekaufmanexpensify Yeah, I think it makes sense

[carlosmiceli]

Great!