[HOLD for payment 2024-10-04][$250] Dupe detect - Invited user is not able to see the receipt placeholder on the confirmation page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Submit two same expenses to the workspace chat.
4. Go to transaction thread (any).
5. Click Review duplicates > Keep this one (any).
6. Proceed to confirmation page.
7. Note that there is a receipt placeholder on the confirmation page.
8. As another user, invite the current user to a workspace.
9. As the invited user, go to workspace chat.
10. Repeat Step 3 to 6.
11. Notet hat there is no receipt placeholder on the confirmation page.

Expected Result:

In Step 11, the invited user should be able to see the receipt placeholder on the confirmation page.

Actual Result:

In Step 11, the invited user is unable to see the receipt placeholder on the confirmation page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6580073_1724396847575.20240823_145830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01741cd4c1fe7a4231
• Upwork Job ID: 1828132802801480968
• Last Price Increase: 2024-08-26

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 11, the invited user is unable to see the receipt placeholder on the confirmation page.

What is the root cause of that problem?

when canEditReceipt=false, we only show Receipt empty state to admin and Approver in here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 382 to 383 in 259a9b7

	const shouldShowReceiptEmptyState =
	isReceiptAllowed && !hasReceipt && !isApproved && !isSettled && (canEditReceipt || isAdmin || isApprover) && (canEditReceipt || ReportUtils.isPaidGroupPolicy(report));

What changes do you think we should make in order to solve the problem?

We should show Receipt empty state to requestor too like we did here

1. Calculate isRequestor based on currentUserPersonalDetails and parentReportAction

    const currentUserPersonalDetails = useCurrentUserPersonalDetails();
    const isRequestor = currentUserPersonalDetails.accountID === parentReportAction?.actorAccountID;

2. Update logic shouldShowReceiptEmptyState here

    const shouldShowReceiptEmptyState =
        isReceiptAllowed && !hasReceipt && !isApproved && !isSettled && (canEditReceipt || isAdmin || isApprover || isRequestor) && (canEditReceipt || ReportUtils.isPaidGroupPolicy(report));

What alternative solutions did you explore? (Optional)

[melvin-bot]

Current assignee @iwiznia is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[iwiznia]

Update logic shouldShowReceiptEmptyState here

Let's make this a method that we use in both places instead of duplicating the logic.

Calculate isRequestor based on currentUserPersonalDetails and parentReportAction

I see your code has parentReportAction?.actorAccountID in what case there's no parentReportAction and how will we determine who is the requestor in that case? Also what exactly is this parent report action? What type is it? When is it added? Are we sure it will match the requestor of the report?

[zanyrenney]

I am heading OOO so please reapply the bug label if this needs payment i the next 7 days, otherwise i'll pay on return!

[daledah]

@iwiznia

Let's make this a method that we use in both places instead of duplicating the logic.

I think this problem will be resolved during PR.

I see your code has parentReportAction?.actorAccountID in what case there's no parentReportAction and how will we determine who is the requestor in that case? Also what exactly is this parent report action? What type is it? When is it added? Are we sure it will match the requestor of the report?

When we create a new expense, the parentReportAction when we open the duplicate confirmation page is the report action created by that expense. Therefore, the actorAccountID in the parentReportAction is requestor.

[daledah]

@allroundexperts PR is ready for review.

[melvin-bot]

This issue has not been updated in over 15 days. @allroundexperts, @roryabraham, @zanyrenney, @daledah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[roryabraham]

The PR for this was deployed to prod on 2024-09-27. Setting payout timer manually.

side-note: working on fixing the automation in #49963

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

Hi! I am going OOO tomorrow when this payment is due, back on 7th October. Could you please handle the payment? I would be happy to take it back if there are any blockers when I am back. Thanks!

[OfstadC]

Old job post expired - new one here

@daledah - Could you please accept this offer? Thank you! 😃

[daledah]

@OfstadC accepted 🙏

[OfstadC]

Payment Summary

• @daledah paid $250 via Upwork
• @allroundexperts due $250 via manual New Expensify request

[JmillsExpensify]

$250 approved for @allroundexperts