[Guided Setup] Sign in – Able to dismiss Onboarding modal when click on browser back button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. In Sign in page enter new Gmail account
3. When Onboarding modal appears click on browser back button

Expected Result:

Onboarding modal is present

Actual Result:

Onboarding modal disappears

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6569986_1723472846308.Onb_m.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @deetergp is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@filip-solecki Could you have a look into this in the morning please?

[Beamanator]

Should we call this NAB if we're ok waiting till morning for a resolution? 🤔

[deetergp]

It really doesn't seem like a blocker…

[Beamanator]

Agreed! Marking NAB!±

[filip-solecki]

Me and @adamgrzybowski are not able to reproduce it, did you try to clear Onyx data?

[mountiny]

Asked in QA if they can repro this on mac too https://expensify.slack.com/archives/C9YU7BX5M/p1723547272644439 the video is from windows

[kavimuru]

Repro in Mac Safari and Mac chrome and mweb

Screen.Recording.2024-08-13.at.15.11.46.mov

Screen.Recording.2024-08-13.at.15.15.04.mov

[adamgrzybowski]

example.mp4

As you can see I can't reproduce it on my end. The difference I noticed in my and your case is that the URL with the report id shows briefly in your.

Not sure why this happens but I won't be able to debug this issue without reliable reproduction steps.

I can point you to this function

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

Lines 103 to 118 in c5feb89

	function shouldPreventReset(state: StackNavigationState<ParamListBase>, action: CommonActions.Action | StackActionType) {
	if (action.type !== CONST.NAVIGATION_ACTIONS.RESET || !action?.payload) {
	return false;
	}
	const currentFocusedRoute = findFocusedRoute(state);
	const targetFocusedRoute = findFocusedRoute(action?.payload);
	// We want to prevent the user from navigating back to a non-onboarding screen if they are currently on an onboarding screen
	if (isOnboardingFlowName(currentFocusedRoute?.name) && !isOnboardingFlowName(targetFocusedRoute?.name)) {
	Welcome.setOnboardingErrorMessage(Localize.translateLocal('onboarding.purpose.errorBackButton'));
	// We reset the URL as the browser sets it in a way that doesn't match the navigation state
	// eslint-disable-next-line no-restricted-globals
	history.replaceState({}, '', getPathFromState(state, linkingConfig.config));
	return true;
	}
	}

I would guess this value const targetFocusedRoute = findFocusedRoute(action?.payload); is wrong. Could you please check it with the debugger? Maybe I will see what is wrong

[deetergp]

@kavimuru Were your reproduction steps on Mac any different than what is listed in the GH description?

[adamgrzybowski]

This may be a race condition. It looks like the initial chat doesn't have time to load and break the behavior on my end.

[melvin-bot]

@deetergp, @anmurali Eep! 4 days overdue now. Issues have feelings too...

[deetergp]

@kavimuru Bump!

[melvin-bot]

@deetergp @anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@deetergp, @anmurali Eep! 4 days overdue now. Issues have feelings too...

[deetergp]

I reached out to @kavimuru in Slack.

[deetergp]

I asked for a retest in Slack but have not yet heard back.

[melvin-bot]

@deetergp, @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

I asked for a retest in Slack but have not yet heard back.

@deetergp can you link the thread when making these kind of references, just helps follow the breadcrumbs. Where are we at with this re-test?

[deetergp]

Of course! This is where I asked previously https://expensify.slack.com/archives/C9YU7BX5M/p1724783266169849, but I think it got lost in the shuffle. Asked again here https://expensify.slack.com/archives/C9YU7BX5M/p1725431001409449

[m-natarajan]

Not reproducible

bandicam.2024-09-04.13-38-15-579.mp4

[trjExpensify]

Cool, so then let's close this out @deetergp?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.