[$250] Currency field is grey out when changing the workspace name

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.17-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1723021392395089

Action Performed:

1. Go to a Workspace - Profile
2. Go offline
3. Change the workspace name

Expected Result:

Only workspace name is grey out. Currency field shouldn't be grey out when changing the workspace name

Actual Result:

Currency field is grey out when changing the workspace name

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.423.mp4

Screen.Recording.2024-08-07.at.16.00.23.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183f6b2d121cb6b9d
• Upwork Job ID: 1821613190575233123
• Last Price Increase: 2024-08-08
• Automatic offers:
• DylanDylann | Reviewer | 103496724
• dominictb | Contributor | 103496725

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency field is grey out when changing the workspace name

What is the root cause of that problem?

We're using the same pendingFields key generalSettings for the name and currency fields here and here

Then when we update a field, the other fields are also grey out

The same problem with company address field here

What changes do you think we should make in order to solve the problem?

We should have a separate pendingFields key for each field and use it in the WorkspaceProfilePage page. We also need to update the pendingFields in onyx data accordingly for each field in the updateGeneralSettings function here and updateAddress function here

What alternative solutions did you explore? (Optional)

[DylanDylann]

I reported this bug, could I take over this issue as C+ role

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0183f6b2d121cb6b9d

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[DylanDylann]

This is straightforward. @dominictb's proposal looks good to me

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @abekkala, @aldo-expensify, @DylanDylann, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[abekkala]

PR has not yet merged to production

[DylanDylann]

@aldo-expensify Please help to check why the PR isn't deployed to prod. The PR was merged 3 weeks ago

[aldo-expensify]

Seems like the automated message Deployed to production... is just missing. I tested in production and I see that the behaviour is there and also the code changes in the production branch.

[aldo-expensify]

@abekkala I think we are ready to pay here, we just missed some part of the automation when the PR was deployed to production.

[abekkala]

PAYMENT SUMMARY:

• Fix: @dominictb [$250] Offer
• PR Review: @DylanDylann [$250] Offer

[abekkala]

@dominictb @DylanDylann payments sent and contracts ended - thank you! 🎉