Skip to content

[HOLD for payment 2024-08-13] [$250] [Search v2.1] [App] Create Category filter #46038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luacmartins opened this issue Jul 23, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 23, 2024

Implement this section of the design doc for the Category filter only!

cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0144ce32afe4e5afaa
  • Upwork Job ID: 1816128900858619869
  • Last Price Increase: 2024-07-24
  • Automatic offers:
    • ikevin127 | Contributor | 103264624
Issue OwnerCurrent Issue Owner: @stephanieelliott
Issue OwnerCurrent Issue Owner: @stephanieelliott
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 23, 2024
@luacmartins luacmartins self-assigned this Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 23, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
@trjExpensify trjExpensify moved this to Release 3: Fall 2024 (Nov) in #expensify-bugs Jul 23, 2024
@289Adam289
Copy link
Contributor

I work for SWM and I would like to work on this issue

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Jul 24, 2024
@melvin-bot melvin-bot bot changed the title [Search v2] [App] Create Category filter [$250] [Search v2] [App] Create Category filter Jul 24, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0144ce32afe4e5afaa

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 24, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 24, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@289Adam289
Copy link
Contributor

Hi! I noticed that each policyID has its own list of categories, but the search is global. What categories should be included on the category page? And should it allow for multiple categories to be selected at once?

@luacmartins
Copy link
Contributor Author

@289Adam289 great questions. I think the behavior should be:

  1. If no policy is selected (via the workspace switcher), show all categories we have in Onyx for all categories
  2. If a policy is selected, show only categories for that policy
  3. Yes, we should allow multi-select

@luacmartins luacmartins assigned ikevin127 and unassigned akinwale Jul 25, 2024
Copy link

melvin-bot bot commented Jul 25, 2024

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@luacmartins
Copy link
Contributor Author

Reassigning to @ikevin127 as per https://expensify.slack.com/archives/C02NK2DQWUX/p1721856187160359

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 30, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 30, 2024
@luacmartins luacmartins changed the title [$250] [Search v2] [App] Create Category filter [$250] [Search v2.1] [App] Create Category filter Jul 31, 2024
@luacmartins luacmartins moved this from Release 3: Fall 2024 (Nov) to Release 2: Summer 2024 (Aug) in #expensify-bugs Jul 31, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 6, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Search v2.1] [App] Create Category filter [HOLD for payment 2024-08-13] [$250] [Search v2.1] [App] Create Category filter Aug 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Aug 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@ikevin127
Copy link
Contributor

@luacmartins Should I try and come up with a regression test for this specific issue or will this be done later when the new search is completed ?

@luacmartins
Copy link
Contributor Author

No, we'll add it as part of the project wrap up

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 12, 2024
@ikevin127
Copy link
Contributor

cc @stephanieelliott

@stephanieelliott
Copy link
Contributor

Summarizing payment on this issue:

Upwork job is here: https://www.upwork.com/jobs/~0144ce32afe4e5afaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

5 participants