Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] [$250] [Search v2.1] [App] Create Merchant filter #46032

Closed
luacmartins opened this issue Jul 23, 2024 · 14 comments
Closed

[PAID] [$250] [Search v2.1] [App] Create Merchant filter #46032

luacmartins opened this issue Jul 23, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 23, 2024

Implement this section of the design doc for the Merchant filter only!

cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ef7bc40a6c8da319
  • Upwork Job ID: 1817944284206858054
  • Last Price Increase: 2024-07-29
Issue OwnerCurrent Issue Owner: @strepanier03
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 23, 2024
@luacmartins luacmartins self-assigned this Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 23, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
@trjExpensify trjExpensify moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Jul 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

@strepanier03, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

@luacmartins
Copy link
Contributor Author

All yours @SzymczakJ!

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ef7bc40a6c8da319

@melvin-bot melvin-bot bot changed the title [Search v2] [App] Create Merchant filter [$250] [Search v2] [App] Create Merchant filter Jul 29, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2024
@luacmartins luacmartins changed the title [$250] [Search v2] [App] Create Merchant filter [$250] [Search v2.1] [App] Create Merchant filter Jul 31, 2024
@luacmartins luacmartins moved this from Release 3: Fall 2024 (Nov) to Release 2: Summer 2024 (Aug) in [#whatsnext] #expense Jul 31, 2024
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 31, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 31, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 6, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Search v2.1] [App] Create Merchant filter [HOLD for payment 2024-08-13] [$250] [Search v2.1] [App] Create Merchant filter Aug 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @ikevin127 requires payment (Needs manual offer from BZ)
  • @SzymczakJ does not require payment (Contractor)

Copy link

melvin-bot bot commented Aug 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@ikevin127
Copy link
Contributor

@luacmartins Should I try and come up with a regression test for this specific issue or will this be done later when the new search is completed ?

@luacmartins
Copy link
Contributor Author

No, we'll add them as part of the project wrap up

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 12, 2024
@ikevin127
Copy link
Contributor

cc @strepanier03

Copy link

melvin-bot bot commented Aug 13, 2024

Payment Summary

Upwork Job

BugZero Checklist (@strepanier03)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1817944284206858054/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@strepanier03 strepanier03 changed the title [HOLD for payment 2024-08-13] [$250] [Search v2.1] [App] Create Merchant filter [PAID] [$250] [Search v2.1] [App] Create Merchant filter Aug 13, 2024
@strepanier03
Copy link
Contributor

Contract accepted, paid, and closed - thanks @ikevin127 🙌

Closing this out now, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

4 participants