Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice bank accounts section #45177

Closed
madmax330 opened this issue Jul 10, 2024 · 15 comments
Closed

Invoice bank accounts section #45177

madmax330 opened this issue Jul 10, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@madmax330
Copy link
Contributor

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.27ed1nyheq5
Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

Manual Test Steps

Automated Tests

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 9, 2024

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@danielrvidal
Copy link
Contributor

@rezkiy37 is this done now or are we waiting for anything?

@rezkiy37
Copy link
Contributor

Discussion in Slack.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Sep 3, 2024

Hey!
I will be OOO from 04.09 (afternoon) till 09.09. I will continue to work on this one once I am back.

@rezkiy37
Copy link
Contributor

Hello!
I am OOO from 19.09 - 23.09. I will continue to work on this one when I am back. Meanwhile, @waterim will work on this issue.

@rezkiy37
Copy link
Contributor

I've integrated the SetInvoicingTransferBankAccount command. I am implementing other front-end parts.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Sep 26, 2024
@Pujan92
Copy link
Contributor

Pujan92 commented Sep 26, 2024

I requested for the doc access

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

This issue has not been updated in over 15 days. @madmax330, @rezkiy37 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 21, 2024
@davidcardoza davidcardoza added Weekly KSv2 and removed Monthly KSv2 labels Oct 22, 2024
@davidcardoza
Copy link
Contributor

What's the latest update on this?

@Pujan92
Copy link
Contributor

Pujan92 commented Oct 22, 2024

Changes were in production 3 weeks ago, so now this is due for the payment.

@rezkiy37
Copy link
Contributor

The PR (#47218) was merged. So we can finish with the issue.

@madmax330 madmax330 added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 23, 2024
@madmax330
Copy link
Contributor Author

@sonialiap for this one can you just do the payment for 2 reviews for @Pujan92 ?

@sonialiap
Copy link
Contributor

Payment summary:

  • @Pujan92 $500 per Max's comment, for review of two PRs - Please request in ND

@github-project-automation github-project-automation bot moved this from Critical to Done in [#whatsnext] #billpay Oct 24, 2024
@garrettmknight
Copy link
Contributor

$500 approved for @Pujan92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

7 participants