Skip to content

Submit expenses to updated approver when Processing for original approver already exists #42706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garrettmknight opened this issue May 28, 2024 · 3 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@garrettmknight
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: All
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1716909164800879

Action Performed:

Pre-reqs:

  • Workspace on Instant Submit
  • Approver set to Approver A
  1. As submitter, create an expense in your workspace chat.
  2. The expense is assigned to Approver A.
  3. As an admin, change the approver for the workspace to Approver B.
  4. As a submitter, create another expense in the workspace chat

Expected Result:

Expense #2 should be assigned to Approver B.

Actual Result:

Expense #2 is added to the existing report assigned to Approver A.

Workaround:

Approver A needs to approve the report in order for a new report assigned to Approver B to be created.

Platforms:

All

View all open jobs on GitHub

@garrettmknight garrettmknight added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels May 28, 2024
@garrettmknight garrettmknight self-assigned this May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Current assignee @garrettmknight is eligible for the Bug assigner, not assigning anyone new.

@garrettmknight garrettmknight moved this from HOT PICKS to Polish in [#whatsnext] #wave-collect May 28, 2024
@melvin-bot melvin-bot bot added the Overdue label May 30, 2024
@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 30, 2024
@garrettmknight
Copy link
Contributor Author

Awaiting a volunteer - will probably clean this up as part of Instant Submit for Control.

@garrettmknight
Copy link
Contributor Author

We decided not to change this behavior since it could be seen as expected. The core problem we'll need to solve is really moving reports from one approver to another in the case that the original approver is not longer able to approve. I think that will fit under a different project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant