Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-05-22 #42496

Closed
45 tasks done
github-actions bot opened this issue May 22, 2024 · 17 comments
Closed
45 tasks done

Deploy Checklist: New Expensify 2024-05-22 #42496

github-actions bot opened this issue May 22, 2024 · 17 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2024

Release Version: 1.4.75-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 23, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.75-0 🚀

@kbecciv
Copy link

kbecciv commented May 23, 2024

Prod QA #42286 and #42288 - checking off

@Julesssss
Copy link
Contributor

Demoting #42519

@blimpich
Copy link
Contributor

Demoting #42540

@kbecciv
Copy link

kbecciv commented May 23, 2024

TR is 16% left

#40354 is pending validation
#41050 is pending validation, left comment #41050 (comment)
#41622 is failing with #42540
#41627 is failing with #42534
#41706 is failing with #41883, repro in prod - is it ok checking off?
#42020 is failing with #42020 on Web, Android and IOS app
#42420 the same PR as #40354, checking off

Deploy Blockers:
#42523
#42557

@kbecciv
Copy link

kbecciv commented May 23, 2024

@mountiny @Julesssss Is this PR #41050 for automated tests?

@mountiny
Copy link
Contributor

@kbecciv yeah should be NoQA

@mountiny
Copy link
Contributor

Demoted #42557

@chiragsalian
Copy link
Contributor

#41706 is failing with #41883, repro in prod - is it ok checking off?

Yeah that's fine, checking it off.

#42020 is failing with #42020 on Web, Android and IOS app

I think you meant failing on #42522. If so do you mean always or only for the specific case mentioned in #42522?

@mvtglobally
Copy link

mvtglobally commented May 24, 2024

TR is at 4%. We will post the final summary in the morning EST

@kbecciv
Copy link

kbecciv commented May 24, 2024

Regression is completed!

#40354 is failing with #42563
#41622 is failing with #42540
#41627 is failing with #42534
#42020 is failing with #42522

Deploy Blocker:
#42523

@kbecciv
Copy link

kbecciv commented May 24, 2024

#42020 is failing with #42020 on Web, Android and IOS app

Correct, I meant #42522. The issue is consistently reproducible, and behavior is expected #42522 (comment)

@chiragsalian
Copy link
Contributor

Checking off #40354 - reasoning
Checking off #41622 - reasoning
Checking off #41627 - reasoning

@chiragsalian
Copy link
Contributor

Checking off #42020 - reasoning

@amyevans
Copy link
Contributor

Checked off #42523 after Applause verified in staging

@isagoico
Copy link

#42599 Checking it off. Retest executed here

@puneetlath
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests