[HOLD for payment 2024-04-25] Workspace - Deleting a message on "Announce" room takes user to another report page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-13
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : https://github.com/Expensify/Expensify/issues/365980
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a new workspace
3. Go to the "#announce" room of the same workspace
4. Send a message
5. Delete the sent message

Expected Result:

Page should be in announce room after deleting the message

Actual Result:

Page redirects to another page after deleting the message e.g page navigates to workspace chat page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6452101_1713342012232.bandicam_2024-04-17_11-19-45-791.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@trjExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[hungvu193]

Regression from this one: #40155
This line:

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

Lines 277 to 279 in 967f9b0

	if (!((reportAction?.childVisibleActionCount ?? 0) > 0)) {
	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportIDRef.current));
	}

cc @rayane-djouah

[youssef-lr]

Thanks @hungvu193! @rayane-djouah @rushatgabhane can you guys take a look please?

[rayane-djouah]

PR ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Workspace - Deleting a message on Announce room takes user to another report page #40368

If no regressions arise, payment will be issued on 2024-04-25. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Determine if we should create a regression test for this bug.
• [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[roryabraham]

this was a regression fixed on staging by the author of the PR that caused it, so we can close this out without payment