Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRITICAL: [Actionable Whispers] Incorrect amount in paid message in LHN when there is tracking and request #40042

Closed
6 tasks done
m-natarajan opened this issue Apr 10, 2024 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat with no request history.
  3. Create a track manual expense ($10) with merchant A.
  4. Create a $5 manual request (not track expense) with merchant B.
  5. Go to expense report.
  6. Submit and approve the report
  7. Pay elsewhere the report.

Expected Result:

In Step 6, the approval message should show the correct amount.
In Step 7, the system message for payment should show the correct amount in LHN preview.

Actual Result:

In Step 6, the approval message shows the total amount first ($15), then changes to the correct amount ($5).
In Step 7, the system message for payment should $15 in LHN, while it shows $5 in the expense report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445069_1712780670198.20240411_042327.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014206f890a94df05c
  • Upwork Job ID: 1778171219909632000
  • Last Price Increase: 2024-04-10
Issue OwnerCurrent Issue Owner: @thienlnam
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 10, 2024
@thienlnam thienlnam assigned thienlnam and unassigned cead22 Apr 10, 2024
@thienlnam
Copy link
Contributor

Not a blocker, requires a BE change to ensure we send back the total not just the reimbursable total

@thienlnam thienlnam added the Internal Requires API changes or must be handled by Expensify staff label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014206f890a94df05c

Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @shubham1206agra (Internal)

@trjExpensify
Copy link
Contributor

Track expense is a #vip-vsb project, moving it over.

@laurenreidexpensify
Copy link
Contributor

@thienlnam are you taking on this issue as the BE engineer?

@thienlnam
Copy link
Contributor

Yup, taking this on

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

@thienlnam, @shubham1206agra, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam
Copy link
Contributor

Tying together with #40266

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 16, 2024
@thienlnam thienlnam changed the title Track expense - Incorrect amount in paid message in LHN when there is tracking and request [HOLD #40266] Track expense - Incorrect amount in paid message in LHN when there is tracking and request Apr 18, 2024
@thienlnam
Copy link
Contributor

Held on #40266

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@thienlnam thienlnam moved this to CRITICAL in [#whatsnext] #vip-vsb Apr 19, 2024
@quinthar quinthar changed the title [HOLD #40266] Track expense - Incorrect amount in paid message in LHN when there is tracking and request CRITICAL: [Actionable Whispers] [HOLD #40266] Incorrect amount in paid message in LHN when there is tracking and request Apr 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@laurenreidexpensify laurenreidexpensify changed the title CRITICAL: [Actionable Whispers] [HOLD #40266] Incorrect amount in paid message in LHN when there is tracking and request [HOLD #40266] CRITICAL: [Actionable Whispers] Incorrect amount in paid message in LHN when there is tracking and request Apr 22, 2024
@laurenreidexpensify laurenreidexpensify changed the title [HOLD #40266] CRITICAL: [Actionable Whispers] Incorrect amount in paid message in LHN when there is tracking and request CRITICAL: [Actionable Whispers] [HOLD #40266] Incorrect amount in paid message in LHN when there is tracking and request Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

@thienlnam, @shubham1206agra, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Apr 22, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@thienlnam
Copy link
Contributor

Still held on #40266 - if we could find an internal engineer to take that, that would be great

@quinthar
Copy link
Contributor

is this still held if #40266 is no longer reproducible?

@quinthar quinthar changed the title CRITICAL: [Actionable Whispers] [HOLD #40266] Incorrect amount in paid message in LHN when there is tracking and request CRITICAL: [Actionable Whispers] Incorrect amount in paid message in LHN when there is tracking and request Apr 25, 2024
@thienlnam
Copy link
Contributor

Should be resolved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

7 participants