Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track expense - Track distance expense does not show up in self DM #40029

Closed
4 of 6 tasks
kbecciv opened this issue Apr 10, 2024 · 9 comments
Closed
4 of 6 tasks

Track expense - Track distance expense does not show up in self DM #40029

kbecciv opened this issue Apr 10, 2024 · 9 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Apr 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #39190
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Self DM has no previous track expenses.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Go to + > Track expense.
  4. Go to Distance tab.
  5. Create track distance expense.

Expected Result:

The track distance expense will show up in self DM.

Actual Result:

The track distance expense does not show up in self DM, but it shows preview in LHN.
This issue only happens when there is no track expense in the self DM. The missing distance request reappears after creating the second request.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6444887_1712774076814.20240411_022950.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 10, 2024

We think that this bug might be related to #wave-collect - Release 1

@NikkiWines
Copy link
Contributor

cc: @neil-marcellini since it looks like this is a result of #39190

@NikkiWines
Copy link
Contributor

Looks like adding a second track expenses results in both track expenses showing in the self-DM. Regardless this looks like it's currently behind a beta, so going to remove the blocker label.

@NikkiWines NikkiWines added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 10, 2024
@shubham1206agra
Copy link
Contributor

This might be a problem before distance track expense.

@paultsimura Can you confirm this problem's origin?

@paultsimura
Copy link
Contributor

I cannot verify 100% because the tracking expense removal fails on BE currently.
But this might be resolved by #40067, let's hold for it.

@neil-marcellini
Copy link
Contributor

I'll take this over since it might be related to my PR. It sounds like that PR above fixed this. I'll test on staging now.

@neil-marcellini
Copy link
Contributor

Yep, fixed. Thanks @paultsimura!

Screen.Recording.2024-04-11.at.10.46.11.AM.mov

@NikkiWines NikkiWines self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants