[$500] [Distance] - Request money does not work with email & phone number

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to + > request money > distance > choose start and end point > next
2. Observe it says name, email and phone number
3. Attempt to add an email. Verify you cannot create a request money report
4. Attempt to change the amount. Verify that you are unable to.
5. Attempt to add a phone number. Verify you cannot create a request money report

Expected Result:

Since email and phone number are said to be accepted, request money reports should be created using both.

Actual Result:

Email and phone number does not have reimbursement detail and hence, a report cannot be created but mentioning email and phone number can be misleading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

email.phone.number.mp4

Recording.4346.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693872152503239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01784d0162b22d689f
• Upwork Job ID: 1700253362770354176
• Last Price Increase: 2023-09-08

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Misleading- Distance request money does not work with email & phone number

What is the root cause of that problem?

In MoneyRequestParticipantsSelector, We disable the P2P option here but we don't exclude the invited user for distance request

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 93 in db1a306

!this.props.isDistanceRequest,

What changes do you think we should make in order to solve the problem?

In MoneyRequestParticipantsSelector, we should pass canInviteUser params as false here to exclude the invited user option for distance request.

return OptionsListUtils.getNewChatOptions(
  this.props.reports,
  this.props.personalDetails,
  this.props.betas,
  searchTerm,
  [],
  CONST.EXPENSIFY_EMAILS,

  // If we are using this component in the "Request money" flow then we pass the includeOwnedWorkspaceChats argument so that the current user
  // sees the option to request money from their admin on their own Workspace Chat.
  this.props.iouType === CONST.IOU.MONEY_REQUEST_TYPE.REQUEST,

  // We don't want to include any P2P options like personal details or reports that are not workspace chats for certain features.
  !this.props.isDistanceRequest,
  false,
  {},
  [],
  !this.props.isDistanceRequest
);

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 93 in db1a306

!this.props.isDistanceRequest,

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.07-09-2023.16.47.27.webm

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01784d0162b22d689f

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Distance] - Request money does not work with email & phone number

What is the root cause of that problem?

Distance request is only for workspace chat for now. Not possible with personal contacts.
So the real confusion here is wrong input label - Name, email or phone number

What changes do you think we should make in order to solve the problem?

For distance request, we can update label like "Workspace name" here.
There's already util to check if distance request so we can reuse that function.
We may need copy for both English and Spanish.

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money does not work with email & phone number

What is the root cause of that problem?

We already disable includeP2P in getRequestOptions which mean we can't send request to normal users.

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 92 to 93 in f896f71

	// We don't want to include any P2P options like personal details or reports that are not workspace chats for certain features.
	!this.props.isDistanceRequest,

But in OptionsListUtils.js, we still send userToInvite while includeP2P = false, and send it base on canInviteUser only

App/src/libs/OptionsListUtils.js

Line 1044 in f896f71

userToInvite: canInviteUser ? userToInvite : null,

What changes do you think we should make in order to solve the problem?

We need to prevent send userToInvite when includeP2P is false here.

// userToInvite: canInviteUser ? userToInvite : null,
userToInvite: includeP2P && canInviteUser ? userToInvite : null,

What alternative solutions did you explore? (Optional)

[maddylewis]

hm, it looks like melv assigned sasha to this one first so i am going to un-assign myself from this one.

[sakluger]

I think the issue here is that when you send a distance request to an email instead of to a workspace, there is no mileage rate set up. I'm going to post this in Slack to see if we've considered this case already.
https://expensify.slack.com/archives/C05DWUDHVK7/p1694466336366829

[sakluger]

This is a known limitation that we haven't built yet. I'm closing this in favor of #23291 which is where we're building the functionality.