Skip to content

Commit f5037de

Browse files
jasperhuanggOSBotify
authored andcommitted
Merge pull request #50025 from Expensify/revert-49250-@Skalakid/inline-images-feature
Revert "Add inline images preview to the Live Markdown Input on the web" (cherry picked from commit 7108478) (CP triggered by jasperhuangg)
1 parent a5e16f9 commit f5037de

File tree

5 files changed

+9
-25
lines changed

5 files changed

+9
-25
lines changed

Diff for: ios/Podfile.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -2360,7 +2360,7 @@ PODS:
23602360
- RNGoogleSignin (10.0.1):
23612361
- GoogleSignIn (~> 7.0)
23622362
- React-Core
2363-
- RNLiveMarkdown (0.1.159):
2363+
- RNLiveMarkdown (0.1.143):
23642364
- DoubleConversion
23652365
- glog
23662366
- hermes-engine
@@ -2380,9 +2380,9 @@ PODS:
23802380
- ReactCodegen
23812381
- ReactCommon/turbomodule/bridging
23822382
- ReactCommon/turbomodule/core
2383-
- RNLiveMarkdown/common (= 0.1.159)
2383+
- RNLiveMarkdown/common (= 0.1.143)
23842384
- Yoga
2385-
- RNLiveMarkdown/common (0.1.159):
2385+
- RNLiveMarkdown/common (0.1.143):
23862386
- DoubleConversion
23872387
- glog
23882388
- hermes-engine
@@ -3229,7 +3229,7 @@ SPEC CHECKSUMS:
32293229
RNFS: 4ac0f0ea233904cb798630b3c077808c06931688
32303230
RNGestureHandler: 8781e2529230a1bc3ea8d75e5c3cd071b6c6aed7
32313231
RNGoogleSignin: ccaa4a81582cf713eea562c5dd9dc1961a715fd0
3232-
RNLiveMarkdown: 2d97e3f4952c642cdd31bc05555e44dc5edcdba1
3232+
RNLiveMarkdown: e44918843c2638692348f39eafc275698baf0444
32333233
RNLocalize: d4b8af4e442d4bcca54e68fc687a2129b4d71a81
32343234
rnmapbox-maps: 460d6ff97ae49c7d5708c3212c6521697c36a0c4
32353235
RNPermissions: 0b1429b55af59d1d08b75a8be2459f65a8ac3f28

Diff for: package-lock.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
},
6969
"dependencies": {
7070
"@dotlottie/react-player": "^1.6.3",
71-
"@expensify/react-native-live-markdown": "0.1.159",
71+
"@expensify/react-native-live-markdown": "0.1.143",
7272
"@expo/metro-runtime": "~3.2.3",
7373
"@firebase/app": "^0.10.10",
7474
"@firebase/performance": "^0.6.8",

Diff for: src/hooks/useMarkdownStyle.ts

-13
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,6 @@ function useMarkdownStyle(message: string | null = null, excludeStyles: Array<ke
7575
color: theme.mentionText,
7676
backgroundColor: theme.mentionBG,
7777
},
78-
inlineImage: {
79-
minWidth: variables.inlineImagePreviewMinSize,
80-
minHeight: variables.inlineImagePreviewMinSize,
81-
maxWidth: variables.inlineImagePreviewMaxSize,
82-
maxHeight: variables.inlineImagePreviewMaxSize,
83-
borderRadius: variables.componentBorderRadius,
84-
marginTop: 4,
85-
},
86-
loadingIndicator: {
87-
primaryColor: theme.spinner,
88-
secondaryColor: `${theme.spinner}33`,
89-
},
90-
loadingIndicatorContainer: {},
9178
};
9279

9380
if (excludeStyles.length) {

Diff for: src/styles/variables.ts

-3
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,6 @@ export default {
248248

249249
searchTypeColumnWidth: 52,
250250

251-
inlineImagePreviewMinSize: 64,
252-
inlineImagePreviewMaxSize: 148,
253-
254251
composerTooltipShiftHorizontal: 10,
255252
composerTooltipShiftVertical: -10,
256253
gbrTooltipShiftHorizontal: -20,

0 commit comments

Comments
 (0)