🥼 feat: Dynamic list of all collaborators for this repo! #203
Conversation
|
@pnu-s @codeurimpulsif 👋 hey can you please review and merge this pr and #202 |
| @@ -0,0 +1,14 @@ | |||
| <div class="row justify-content-md-center"> | |||
| {{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }} | |||
There was a problem hiding this comment.
| {{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }} | |
| {{ $data := getJSON "https://api.github.com/orgs/Exodus-Privacy/members" }} |
or
| {{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }} | |
| {{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/exodus/contributors" }} |
There was a problem hiding this comment.
Wait a min,
We want org members or inactive contributors?
Repo of website or app or exodus?
There was a problem hiding this comment.
Suggested change
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }} {{ $data := getJSON "https://api.github.com/orgs/Exodus-Privacy/members" }} or
Suggested change
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }} {{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/exodus/contributors" }}
|
There was a problem hiding this comment.
Hi, thanks but I don't think it's a good thing to add this kind of automated listing from Github (it show old contributors), also not everyone in this list want to be in the Exodus Privacy website or want to use the Github description as a description on the Exodus Privacy website. And this method delete lot of users links.
Also: I don't think we want to make a query to Github for this.
Ohh mate I just tried to solve an issue #85 |
Closes #85
Screen shots:;