Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: separate internal/external amount representation #952

Closed
kilrau opened this issue May 7, 2019 · 2 comments
Closed

grpc: separate internal/external amount representation #952

kilrau opened this issue May 7, 2019 · 2 comments
Assignees
@ImmanuelSegol
Labels
grpc gRPC API P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented May 7, 2019 •
edited
Loading

grpc (& CLI): decimals
internal: 1E8 integers for all coins and tokens (BTC/LTC/ERC20)

Motivation:
Currently it's 1E8 on the grpc which is dangerous for ERC20 tokens.

Notes:
@kilrau kilrau added the grpc gRPC API label May 7, 2019
@kilrau kilrau modified the milestones: post-1.0.0, 1.0.0 May 7, 2019
@kilrau kilrau mentioned this issue May 8, 2019
Closed
@kilrau kilrau added the P2 mid priority label May 8, 2019
@ImmanuelSegol ImmanuelSegol self-assigned this May 8, 2019
@kilrau kilrau modified the milestones: 1.0.0, post-1.0.0 Jun 5, 2019
@ghost
Copy link

ghost commented Jul 22, 2019

Think we can close this?

CC @sangaman

@kilrau
Copy link
Contributor Author

kilrau commented Jul 22, 2019

Yes.

@kilrau kilrau closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImmanuelSegol ImmanuelSegol

Labels
grpc gRPC API P2 mid priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ImmanuelSegol @kilrau