Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pretty cli listpairs #925

Merged
merged 13 commits into from
Jun 8, 2019
Merged

feat: pretty cli listpairs #925

merged 13 commits into from
Jun 8, 2019

Conversation

ImmanuelSegol
Copy link
Contributor

#558
Formates listpairs cli response.

@ImmanuelSegol ImmanuelSegol requested review from sangaman and a user April 29, 2019 09:24
sangaman
sangaman reviewed Apr 29, 2019
View reviewed changes
Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Just a few comments/suggestions.

@ImmanuelSegol ImmanuelSegol self-assigned this Apr 29, 2019
@ImmanuelSegol ImmanuelSegol requested a review from sangaman May 2, 2019 14:03
@ghost
Copy link

ghost commented May 4, 2019

Looks good.

@sangaman @ImmanuelSegol
Minor nit. I'm wondering if it makes sense to display the Base and Quote in a separate column? We're also displaying the same information in the PairId column. What do you think about renaming it to Pair Base/Quote and losing the Base and Quote columns?

@kilrau
Copy link
Contributor

kilrau commented May 6, 2019

What do you think about renaming it to Pair Base/Quote and losing the Base and Quote columns?

Pair (Base/Quote) 👍 @ImmanuelSegol @erkarl

@sangaman sangaman added the command line (CLI) Relating to the command line interface tools label May 14, 2019
sangaman
sangaman requested changes May 14, 2019
View reviewed changes
@ImmanuelSegol ImmanuelSegol requested a review from sangaman May 20, 2019 15:31
sangaman
sangaman reviewed May 30, 2019
View reviewed changes
@kilrau kilrau self-requested a review June 7, 2019 17:33
kilrau
kilrau approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kilrau@K-Yoga:~/xud/bin$ ./xucli addpair btc ltc
success
kilrau@K-Yoga:~/xud/bin$ ./xucli listpairs
Trading Pairs:
┌──────────────┐
│ Trading pair │
├──────────────┤
│ LTC / BTC    │
├──────────────┤
│ BTC / LTC    │

@sangaman sangaman merged commit 0347d60 into master Jun 8, 2019
@sangaman sangaman deleted the pretty-cli-listpairs branch June 8, 2019 02:23
sangaman pushed a commit that referenced this pull request Jun 8, 2019
@ImmanuelSegol @sangaman
feat(cli): enhance output of listpairs (#925)
6852ea2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangaman sangaman sangaman approved these changes

@kilrau kilrau kilrau approved these changes

Assignees

@ImmanuelSegol ImmanuelSegol

Labels
command line (CLI) Relating to the command line interface tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImmanuelSegol @kilrau @sangaman