improved streamOrders #687 #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsercano
added
the
command line (CLI)
ghost
added
the
moshababo
reviewed
Jan 7, 2019
moshababo
approved these changes
Jan 7, 2019
sangaman
reviewed
Jan 8, 2019
sangaman
approved these changes
Jan 15, 2019
lib/cli/commands/subscribeorders.ts
Outdated
| @@ -18,8 +18,11 @@ export const handler = (argv: Arguments) => { | |||
| ensureConnection(argv, true); | |||
| }; | |||
|
|
|||
| let xud: any; | |||
There was a problem hiding this comment.
Minor nit, but this can be XudClient instead of any.
|
If you may squash and merge I would be happier, don't want to take risk to break commit history of master :) @sangaman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again,
this PR fixes #687, I was trying to work on new order types but since there're lots of struggles there I wanted to focus something else, as requested by @offerm I've implemented all the following changes;
In a technical overview; I've implemented those by calling
GetInfoto ensure connection before subscribing anything and if there's noxudnode running then I'm trying to reconnect in3 seconds(let me know if you want to adjust time) This seemed to be the easiest way to me to implement such logic. Btw. error messages are not being printed every 3 seconds it's only being printed at first.