Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending GET_NODES scheduled #402 #770

Merged
merged 15 commits into from
Jan 4, 2019
Merged

Sending GET_NODES scheduled #402 #770

merged 15 commits into from
Jan 4, 2019

Conversation

rsercano
Copy link
Collaborator

resolves #402, please ignore #746

@rsercano rsercano added the p2p Peer to peer networking label Dec 25, 2018
@rsercano rsercano self-assigned this Dec 25, 2018
@rsercano rsercano requested a review from moshababo December 25, 2018 13:17
@ghost ghost added the in progress label Dec 25, 2018
@rsercano rsercano mentioned this pull request Dec 25, 2018
Closed
moshababo
moshababo approved these changes Dec 25, 2018
View reviewed changes
Copy link
Collaborator

@moshababo moshababo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you got a chance to manually test it?

@moshababo
Copy link
Collaborator

You can move the PoolConfig type to lib/types/p2p.ts to avoid the circular dependency.

@rsercano
Copy link
Collaborator Author

rsercano commented Dec 25, 2018 •
edited
Loading

Yes I manually tested it, seems to be working to me, I'll move it tomorrow as first thing to do @moshababo
I don't know why this travis build fails tho,

EDIT: oh it's because circular import, lol gotta fix it.

@rsercano rsercano requested review from sangaman and kilrau December 25, 2018 17:22
@rsercano
Copy link
Collaborator Author

Fixed !

@moshababo moshababo merged commit 57c48de into ExchangeUnion:master Jan 4, 2019
@ghost ghost removed the in progress label Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshababo moshababo moshababo approved these changes

@sangaman sangaman Awaiting requested review from sangaman

@kilrau kilrau Awaiting requested review from kilrau

Assignees

@rsercano rsercano

Labels
p2p Peer to peer networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET_NODES periodically
2 participants
@rsercano @moshababo