feat(p2p): verify data integrity #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
sangaman
approved these changes
Dec 17, 2018
| } | ||
| } | ||
| } | ||
| public abstract serialize(): Uint8Array; | ||
|
|
||
| private hash(value: any): string { | ||
| return MD5(stringify(value)).toString(CryptoJS.enc.Base64); |
There was a problem hiding this comment.
It might be nice to have some sanity tests for this method.
There was a problem hiding this comment.
You mean to test against static values (input/output)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #157.
As discussed here, the packet body serialization for the hash function is done with
JSON.stringify. Lack of consistency in the serialization was already found, so I usedjson-stable-stringifyto fix it. Without it the tests would fail.