Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscribeorders.ts): SubscribeAddedOrders should have existing true by default #730

Merged
merged 7 commits into from
Dec 25, 2018

Conversation

ImmanuelSegol
Copy link
Contributor

Closes #728

@ghost ghost assigned ImmanuelSegol Dec 5, 2018
@ghost ghost added the in progress label Dec 5, 2018
Copy link
Contributor

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the code, looks like

@ImmanuelSegol ImmanuelSegol changed the title feat(subscribeorders.ts): add limit to SubscribeAddedOrders issue #728 feat(subscribeorders.ts): add limit to SubscribeAddedOrders Dec 6, 2018
@ImmanuelSegol ImmanuelSegol requested a review from kilrau December 6, 2018 21:25
Copy link
Contributor

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api.md fine now. Rest needs to be reviewed & approved by either @sangaman or @moshababo

Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#728 is not about adding a limit to the order subscription calls. Also, the way this is implemented it will return an arbitrary set of orders, which does not seem useful at all.

@ImmanuelSegol
Copy link
Contributor Author

ImmanuelSegol commented Dec 8, 2018

@sangaman How should I decide which orders should be returned?

@ImmanuelSegol ImmanuelSegol changed the title feat(subscribeorders.ts): add limit to SubscribeAddedOrders feat(subscribeorders.ts): SubscribeAddedOrders should have existing true by default Dec 9, 2018
@sangaman
Copy link
Collaborator

I just don't think we should be returning a subset of orders, and that's not the problem highlighted in the issue, so I think we should stick to returning all orders up front when existing is true.

@sangaman
Copy link
Collaborator

@ImmanuelSegol Will you be able to fix this typo soon? I think it makes sense to merge this before the next release and obviously the change is very minor, but if you're busy I can handle it.

@sangaman sangaman merged commit a40b330 into master Dec 25, 2018
@ghost ghost removed the in progress label Dec 25, 2018
@michael1011 michael1011 deleted the subscribeaddedorders-fix branch March 14, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants